Binary Tree Problems

This is a discussion on Binary Tree Problems within the C++ Programming forums, part of the General Programming Boards category; I followed a textbook example of how to implement a binary tree using template classes, but have needed to modify ...

  1. #1
    HelpingYouHelpUsHelpUsAll
    Join Date
    Dec 2007
    Location
    In your nightmares
    Posts
    223

    Binary Tree Problems

    I followed a textbook example of how to implement a binary tree using template classes, but have needed to modify the (private) insert function to accept another treeNode * for the parent (I want to be able to remove nodes later), but the debugger has trouble getting past aRoot = new treeNode. With the first node, root points to 0 and Eclipse debugger says &aRoot = @0x0. I think it is trying to read memory from address 0 when it shouldn't be. Where I test if aRoot is 0, the program terminates if I don't use (&aRoot == 0). It used to work, but I cannot figure out what is wrong.

    Code:
    if (&aRoot == 0) { // was if (aRoot == 0) in the book
    Code:
    template<class treeElement>
    bool binaryTree<treeElement>::insert(const treeElement &el) {
        treeNode *parent = 0;
        return insert(root, el, parent);
    }
    
    template<class treeElement>
    bool binaryTree<treeElement>::insert(treeNode *&aRoot, const treeElement &el,
        treeNode *parent) {
    
        if (&aRoot == 0) {
            aRoot = new treeNode;
            aRoot->left = 0;     //doesn't execute
            aRoot->right = 0;
            aRoot->info = el;
            aRoot->parent = parent;
            return true;
        }
        else if (el == aRoot->info) return false;
        else if (el <= aRoot->info)
            return insert(aRoot->left, el, aRoot);
        else return insert(aRoot->right, el, aRoot);
    }
    long time no C; //seige
    You miss 100% of the people you don't C;
    Code:
    if (language != LANG_C && language != LANG_CPP)
        drown(language);

  2. #2
    and the Hat of Guessing tabstop's Avatar
    Join Date
    Nov 2007
    Posts
    14,185
    Is treeNode supposed to be a template class too? (Edit: I'm guessing here based on the fact that new Treenode seems to be the problem.)

  3. #3
    HelpingYouHelpUsHelpUsAll
    Join Date
    Dec 2007
    Location
    In your nightmares
    Posts
    223
    treeNode is a struct for the internal representation of the class binaryTree. treeNode contains three treeNode pointers and info of type treeElement (the type that you specify when you create each instance of the class). root is also a treeNode*.
    long time no C; //seige
    You miss 100% of the people you don't C;
    Code:
    if (language != LANG_C && language != LANG_CPP)
        drown(language);

Popular pages Recent additions subscribe to a feed

Similar Threads

  1. please help with binary tree, urgent.
    By slickestting in forum C Programming
    Replies: 2
    Last Post: 07-22-2007, 08:55 PM
  2. Tutorial review
    By Prelude in forum A Brief History of Cprogramming.com
    Replies: 11
    Last Post: 03-22-2004, 09:40 PM
  3. Templated Binary Tree... dear god...
    By Nakeerb in forum C++ Programming
    Replies: 15
    Last Post: 01-17-2003, 02:24 AM
  4. binary tree node structure
    By Kirsten in forum C Programming
    Replies: 2
    Last Post: 04-26-2002, 09:02 PM
  5. read records fron file into a binary tree
    By Kirsten in forum C Programming
    Replies: 1
    Last Post: 04-23-2002, 03:48 PM

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21