Thread: Help with my code

Hello. I have to write a program that lets the user guess a number from a random number and say if its too high/low/correct.

However, the part I am stuck on is that after the user guesses it correctly, I need to have it ask if the user wants to play again, whereas the user enters y for yes and n for no.

Here is what my code is so far:

Code:

#include <iostream>

#include <cstdlib>

using namespace std;

int main ()

{

	int a;

	int b;

	srand(a);

	a = rand()%1001;

	cout << "I have a number between 1 and 1000." << endl;

	cout << "Can you guess my number?" << endl;

	
	while (1)

	{

	char again='';

	do

	{

	cout << "Please type your first guess." << endl;	

	cin >> b;
	

	if (b > a)

	
		cout << "Too high. Try again" << endl;


	if (b < a)

		cout << "Too low. Try again." << endl;

	} while (b != a);

		cout << "Excellent! You guessed the number!" << endl;

	while (again != 'y' || again != 'n')

	{
		cout << "Would you like to play again (y or n)?" << endl;

		cin >> again;
	
	}

	if (again == 'n')

		break;

	}
	
	return 0;
}

I am getting an empty character constant in regards to this line:

Code:

char again='';

How do I go about fixing it?

Make it a character, like 'a' or 'q' or even ' '. (That is, with a space between the quotes.)

How do I go about fixing it?

What are you trying to assign to this variable? If you just want to assign some default value that is not 'n' or 'y', then just do:

Code:

char again = 'x';

or

Code:

char again = '\0';

Originally Posted by tabstop

Make it a character, like 'a' or 'q' or even ' '. (That is, with a space between the quotes.)

That seems to have worked, but when it prompts 'Would you like to play again?', entering y or n does not do anything but have it show 'Would you like to play again?'

What is wrong with my while loop?

Code:

while (again != 'y' || again != 'n')

	{
		cout << "Would you like to play again (y or n)?" << endl;

		cin >> again;
	
	}

	if (again == 'n')

		break;

I've changed my code:

Code:

#include <iostream>

#include <cstdlib>

using namespace std;

int main ()

{

	int a;

	int b;

	srand(a);

	a = rand()%10 + 1;

	cout << "I have a number between 1 and 1000." << endl;

	cout << "Can you guess my number?" << endl;

	
	while (1)

	{

	char again = '\0';

	do

	{

	cout << "Please type your first guess." << endl;	

	cin >> b;
	

	if (b > a)

	
		cout << "Too high. Try again" << endl;


	if (b < a)

		cout << "Too low. Try again." << endl;

	} while (b != a);

	{

		cout << "Excellent! You guessed the number!" << endl;

		cout << "Would you like to play again (y or n)?" << endl;

		cin >> again;
	}


	if (again == 'n')

		break;

	}
	
	return 0;
}

now when it runs the program again, the number is still the same as before, how can i fix that?