C++ string problem

Hi I have a problem with this program.

Code:

#include <iostream>
#include <string>
using namespace std;

void welcomeMessage();
string user_information ( string name1, string name2);
void exitMessage ( string name1, string name2);

int main()
{
	string firstname, lastname;
	welcomeMessage();
	user_information ( firstname, lastname );
	exitMessage ( firstname, lastname );
	system("PAUSE");
	return 0;
}

void welcomeMessage()
{
	cout << "Welcome to my C++ program \n";
}

string user_information ( string name1, string name2)
{
	
	cout << "Please give me your first name ";
	cin >> name1;
	cout << "Please give me your last name ";
	cin >> name2;
	return name1 ;
}

void exitMessage ( string name1, string name2)
{
	cout << "Thank you ";
	cout << name1;
	cout << " ";
	cout << name2 << endl;
	cout << "for using my project " << endl;
}

I am not sure what to do. Do I need to convert them to a char array and then use one as input and the other as out put. Any input on this would be great I am stuck with this one.

When you pass a variable to a function, you are actually passing a copy of that variable. Obviously, therefore, any changes to the copies won't be reflected in the originals.

user_information() needs to accept arguments that are non-const references (or pointers) to std::string. That allows you to change the string passed.

I would try the following- change...

Code:

string user_information ( string name1, string name2)
{
	
	cout << "Please give me your first name ";
	cin >> name1;
	cout << "Please give me your last name ";
	cin >> name2;
	return name1 ;
}

To:

Code:

void userInformation(const string& s)
{
   cout << "Please give me your first and last name";
  getline(cin, name);
  
 }

I would try the following- change...

That's wrong in a couple ways. First of all, you pass a variable named "s", and use a variable named "name". Second, you can't pass a const reference to getline().

The correct way to use that approach would be:

Code:

void userInformation(string& name)
{
    cout << "Please give me your first and last name: ";
    getline(cin, name);
}

Got it bithub...I just what look right from the texts on the matter

Forgot to find the parameter problem..and the caveat about getline...

thanks now it works correctly.