Thread: I olny get "4 bytes" of the memory!???

I've taken alot of advice and help and have gotten this far...




Sender/Reader:

Code:

#include <cstdlib>
#include <iostream>
#include <fstream>
#include <socket.cpp>

using namespace std;

int main(int argc, char *argv[])
{
int size = 0;
	
	ServerSocket sok;
	sok.StartHosting(6500);
	
	ifstream bob("Hi.bmp",ios::in|ios::binary);

	
	bob.seekg(0, ios::end);

	size = bob.tellg();
	
	cout<<size<<"\n";

	bob.seekg(0, ios::beg);
	
	char memblock[size];
	
	bob.read(memblock,size);
	
	ofstream joe("Bye.bmp",ios::out|ios::binary);

	
	sok.SendData(memblock);
	
		joe.write(memblock,size);
	
	system("PAUSE");
	return EXIT_SUCCESS;
}

Reciver/Writer:

Code:

#include <cstdlib>
#include <iostream>
#include <fstream>
#include <socket.cpp>

using namespace std;

int main(int argc, char *argv[])
{
	ClientSocket sok;
	sok.ConnectToServer("127.0.0.1",6500);
	
	char *memblock;
	sok.RecvData(memblock,sizeof(memblock));
	
	ofstream joe("Bye.bmp",ios::out|ios::binary);
	joe.write(memblock,sizeof(memblock));
	
	cout<<sizeof(memblock);
	
	system("PAUSE");
	return EXIT_SUCCESS;
}

SOCKET.CPP CODE:

Code:

//Socket.cpp
#include "Socket.h"

Socket::Socket()
{
    if( WSAStartup( MAKEWORD(2, 2), &wsaData ) != NO_ERROR )
    {
        cerr<<"Socket Initialization: Error with WSAStartup\n";
        system("pause");
        WSACleanup();
        exit(10);
    }

    //Create a socket
    mySocket = socket( AF_INET, SOCK_STREAM, IPPROTO_TCP );

    if ( mySocket == INVALID_SOCKET )
    {
        cerr<<"Socket Initialization: Error creating socket"<<endl;
        system("pause");
        WSACleanup();
        exit(11);
    }

    myBackup = mySocket;
}

Socket::~Socket()
{
    WSACleanup();
}

bool Socket::SendData( char *buffer )
{
    send( mySocket, buffer, strlen( buffer ), 0 );
    return true;
}

bool Socket::RecvData( char *buffer, int size )
{
    int i = recv( mySocket, buffer, size, 0 );
    buffer[i] = '\0';
    return true;
}

void Socket::CloseConnection()
{
    //cout<<"CLOSE CONNECTION"<<endl;
    closesocket( mySocket );
    mySocket = myBackup;
}

void Socket::GetAndSendMessage()
{
    char message[STRLEN];
    cin.ignore();//without this, it gets the return char from the last cin and ignores the following one!
    //cout<<"Send > ";
    cin.get( message, STRLEN );
    SendData( message );
}

void ServerSocket::StartHosting( int port )
{
     Bind( port );
     Listen();
}

void ServerSocket::Listen()
{
    //cout<<"LISTEN FOR CLIENT..."<<endl;
    
    if ( listen ( mySocket, 1 ) == SOCKET_ERROR )
    {
        cerr<<"ServerSocket: Error listening on socket\n";
        system("pause");
        WSACleanup();
        exit(15);
    }
    
    //cout<<"ACCEPT CONNECTION..."<<endl;
    
    acceptSocket = accept( myBackup, NULL, NULL );
    while ( acceptSocket == SOCKET_ERROR )
    {
        acceptSocket = accept( myBackup, NULL, NULL );
    }
    mySocket = acceptSocket;
}

void ServerSocket::Bind( int port )
{
    myAddress.sin_family = AF_INET;
    myAddress.sin_addr.s_addr = inet_addr( "0.0.0.0" );
    myAddress.sin_port = htons( port );
    
    //cout<<"BIND TO PORT "<<port<<endl;

    if ( bind ( mySocket, (SOCKADDR*) &myAddress, sizeof( myAddress) ) == SOCKET_ERROR )
    {
        cerr<<"ServerSocket: Failed to connect\n";
        system("pause");
        WSACleanup();
        exit(14);
    }
}

void ClientSocket::ConnectToServer( const char *ipAddress, int port )
{
    myAddress.sin_family = AF_INET;
    myAddress.sin_addr.s_addr = inet_addr( ipAddress );
    myAddress.sin_port = htons( port );
    
    //cout<<"CONNECTED"<<endl;

    if ( connect( mySocket, (SOCKADDR*) &myAddress, sizeof( myAddress ) ) == SOCKET_ERROR )
    {
        cerr<<"ClientSocket: Failed to connect\n";
        system("pause");
        WSACleanup();
        exit(13);
    } 
}

Still olny writes 4 bytes of data. (nothing?)

Do you expect sizeof(memblock) to be something other than 4? If so, why?

(For that matter, do you expect to have actual memory being pointed to by memblock? If so, why?)

To get the size idk actually how, if not that.

Could I just put 100000 in all the "size" areas. My test file is pretty small.

I don't think you've quite got the point. Your receiver/writer, as it stands, can currently write a maximum of zero (0) bytes. You have nowhere to put any data that is received. Once you acquire memory to put the data into, then you will know what the size of the data is.

Could anyone actually suggest what I should do?

Originally Posted by azjherben

Could anyone actually suggest what I should do?

Obtain sufficient memory to place your text somewhere (using one of the alloc functions, I suppose) and then use that memory to write to.

alloc?

I'll google it.