Help

Code:

#include <iostream>
#include <fstream>
#include <cstdlib>
#include <cctype>

using namespace std;

void grades (ifstream& in, ofstream& out);
double avg (ifstream& in, ofstream& out);

int main ()
{
    char next;
    double average;
    
    ifstream fin;
    ofstream fout;
    
    fin.open ("F:\\CS 2\\scores.txt");
    
    if (fin.fail())
    {
       cout << "File failed to open.\n";
       system ("pause");
       exit (1);
    }
    
    fout.open ("F:\\CS 2\\grades.txt");
    
    if (fout.fail())
    {
       cout << "File failed to open.\n";
       system ("pause");
       exit (1);
    }
    
   
    grades (fin, fout);
    
     
    
    fin.close ();
    fout.close ();
    system ("pause>nul");
}


void grades(ifstream& in, ofstream& out)
{
      char next;
      double average;
      
      while (! in.eof())
      {
      in.get(next);
      
      while (next != '\n')
      {
            cout << next;
            out << next;        
            in.get (next);
      }
      average = avg (in, out);
     
      cout << ' ' << average;
      out << ' ' << average;
      }
      
}
   
double avg (ifstream& in, ofstream& out)  
{
      string last, first;
      double score [10], average = 0;
      int i;
      
      out.setf(ios::fixed);
      out.setf(ios::showpoint);
      out.precision(2);
      
       in >> last >> first;       
       for (i = 0; i < 10; i++)
       in >> score[i];
       
       
       average=(score[0]+score[1]+score[2]+score[3]+score[4]+score[5]+score[6]+score[7]+score[8]+score[9])/10;
       
       
       
       return (average);
}

It keeps returning the average as 43.90, which is the average of the scores for the next student. I don't know why though. Can somebody help me please?

Here is the input:

Lo Ma 1 2 3 4 5 6 7 8 9 10
George Michelle 12 23 34 54 65 7 98 23 100 23
Frat Brat 12 12 12 12 12 12 12 12 12 12
Bore More 23 4 56 6 34 4 2 6 8 9

The out put is:
Lo Ma 1 2 3 4 5 6 7 8 9 10 43.90 12.00 15.20

How about printing the scores as you read them in, to see what you are actually averaging.

--
Mats

You aren't processing your input well. The grades function reads and outputs the first line of data (for Lo Ma). Then the avg function is called which reads the next line of data (for George Michelle) and calculates the average based on that person's scores (not Lo Ma's). When you return to the grades function to print the average, you going to end up printing George Michelle's average and not Lo Ma's.

BTW, you should be #including the <string> header.

Originally Posted by hk_mp5kpdw

You aren't processing your input well. The grades function reads and outputs the first line of data (for Lo Ma). Then the avg function is called which reads the next line of data (for George Michelle) and calculates the average based on that person's scores (not Lo Ma's). When you return to the grades function to print the average, you going to end up printing George Michelle's average and not Lo Ma's.

BTW, you should be #including the <string> header.

So the average function picks up where the grades function left off?

Originally Posted by matsp

How about printing the scores as you read them in, to see what you are actually averaging.

--
Mats

It's averaging the next students scores, but I don't know how to fix that.

Originally Posted by Matsuya

So the average function picks up where the grades function left off?

Indeed it does. You are using the same file, which only has one position where it reads from. You should read data ONCE.

--
Mats

Originally Posted by matsp

Indeed it does. You are using the same file, which only has one position where it reads from. You should read data ONCE.

--
Mats

Is there a way to make it go back to the beginning of the file?

Code:

in.get(next);
      
      while (next != '\n')
      {
            cout << next;
            out << next;        
            in.get (next);
      }

What would you say is the purpose of this code?

Originally Posted by anon

Code:

in.get(next);
      
      while (next != '\n')
      {
            cout << next;
            out << next;        
            in.get (next);
      }

What would you say is the purpose of this code?

It's to stop it at the end of the line so I can insert the average before going on to the next student.

Never mind, I've figured it out. Thank you.