Thread: is this code is good?

Code:

	void AddItem(int A)                                  //the arug' the amount you want to add
	{
		int B;                                           //used to contain the subscribed amount
        amount += A;                                     //adds to the amount

		if( amount > stackSize )                         //if the amount is greater then the stacksize
		{
			B = amount - stackSize;                      //it subscribes stackSize from the amount to find out by how much greater
			amount -= B;                                 //and then it subscribes the subscribed amount from the amount
			GetItem(B);                                  //which after then it takes the subscribed amount and calls and calls GetItem so itll add the subscribes amount to a new slot
		}
	}

    void GetItem(int A)                                   //the arug' indicates the amount of the item
	{
		for( int iii=0; iii != MAX_INV; iii++)            //a "for" loop to travel around the slots(arrays)

			if( charInv[iii].id == 0 )                    //if it finds an empy slot(array with NULL id)
			{ 
				charInv[iii] = *this;                     //it copies the item into the slot (representing the item with "*this")
				charInv[iii].additem(A);                  //and the addd the amount of the item
				break;                                    //which after this it breaks the loop so it won't add the same item multiple items
			}                                             //otherwise if the slot isn't empty itll start looking for another slot

			else if( charInv[iii].id == id)               //if it finds slot with the same item(same id)
				if( charInv[iii].amount < stackSize)      //if theres still space left in the stackSize(the amount is less then the stacksize)
				{ 
					charInv[iii].AddItem(A);              //it adds the value to the item(by calling AddItem)
					break;                                //which after this it breaks the loop so it won't add the same item multiple items
				}                                         //otherwise if theres no space left in stackSize itll look for another free slot
	}

is this code is good to follow the comments, is there any possible flaws? (like breaking from the fixed loop of calling and stuf ehich may cause problems)

Originally Posted by matsp

I have no idea what the purpose of this code is.

What if all slots are full up.

You call addItem twice. You could probably do something like this:

Writing a comment for every line is often "too much". Certainly saying something like "for-loop to walk through the array" - well, doh!, it's generally what for-loops do. Comments aren't there to explain what the code itself means, but the overall idea of the code.

I would also add teh rest of the braces, even if they aren't strictly needed.

I also wonder if you should ALWAYS add new elements if there is a zero-id, even is element of that ID with a value in it.

You use both addItem and AddItem - I presume there is only one variant of the name.

Here's something like what you do, but with error checking and only ONE line that does AddItemI().

Code:

void GetItem(int A)
{
    for( int iii=0; iii != MAX_INV; iii++)
    {
	int tmpid = charInv[iii];
	if( tmpid == 0 || (tmpid == id && charInv[iii].amount < stackSize))
	{ 
	    break;
	}
    }

    if (iii != MAX_INV)
    {
	if (charInv[iii] == 0)
	{
	    charInv[iii] = *this; 
	}
	charInv[iii].Additem(A);
    }
    else
    {
	// Handle error : no slots free. 
    }
}

--
Mats

the purpose is just to add item to inventory

oh yeah, thanks for remaining, i was planning to write the code for that but i guess i forgot

Code:

		for( int iii=0; iii <= MAX_INV; iii++)
			if ( iii == MAX_INV)
			{
				cout << "The inventory is full" << endl;
				break;
			}

is calling the same function of separate objects is bad?

i just got carried away with writing the comments(first time writing comments)

what braces?

about the zero id, there's no such item with zero id, each has his own id, so its impossible for a zero id(only if i was daydreaming while coding but even after that i can run a program that checks if there no zero id)

the addItem is just a typo