Thread: C++ compile error, help please

Originally Posted by ExDHaos

Races (int a, string b, string c, string d, string e, float f, float g, float aa, float ab, float ac, float ad,
float ae, float af, float ag, float ba, float bb, float bc, float bd)

Oh dear, that is... excessive.

Originally Posted by ExDHaos

well thats a database class after all >.>

So?

Originally Posted by ExDHaos

but u don't think its the problem, do u?

It is a problem, but it is not the reason for your compile error. The reason is that you appear to be trying to call a constructor as if it were a normal member function:

Code:

DBraces[1].Races(1, "a", "a", "a", "a", 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5);

Anyway, DBraces[1] has already been default constructed by that point.

Originally Posted by ExDHaos

well im really new to coding, is there a better way to make a database class or whatever?

Just as you have made use of arrays as member variables, you can make use of arrays for parameters.

Originally Posted by ExDHaos

and how can i fix it then, is there a way to force the array not to use the defult constructor (it always gave me an erroe if i didn't use one) but well, thx for pointing that out btw

Unfortunately, this is not easy to do by hand. If you are allowed and willing to use a std::vector<Races>, you can then construct a dynamic array of Races objects with your desired constructor.

yaya's suggestion turns construction into a two phase process. Generally, I do not recommend such an approach as I feel that construction should be a single process, either by directly using a constructor, or by some factory function.

Yet, it may well be the case that you are not looking to construct the objects with the given data. Maybe you are actually looking to default construct the objects, and then assign the appropriate data to them. Perhaps some setter functions are appropriate?

Originally Posted by yaya

Laserlight is right, but this is how I'd do the class:

Code:

	void Init (int a, string b, string c, string d, string e, float f, float g, float aa, float ab, float ac, float ad, 
		float ae, float af, float ag, float ba, float bb, float bc, float bd)
	{
	    raceID = a;
	    raceName = b;
	    raceEner = c;
	    raceEP = d;
	    raceDesc = e;
	    raceAttG[0] = f;
	    raceAttG[1] = g;
	    raceAttG[2] = aa;
	    raceAttG[3] = ab;
	    raceResE[0] = ac;
	    raceResE[1] = ad;
	    raceResE[2] = ae;
	    raceResP[0] = af;
	    raceResP[1] = ag;
	    raceResP[2] = ba;
	    raceResM[0] = bb;
	    raceResM[1] = bc;
	    raceResM[2] = bd;
	}

	Races ()
	{
		Init (1, "a", "a", "a", "a", 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5);
	}

So then you would simply construct your object, and if you didn't like the way it turned out, you can call Init() again, though directly for the second time. The main problem with this is that you are initializing everything twice, which is never good and will be slow if you do it heaps. But it is an option.

thanks, ur suggestion gave me another idea

Code:

#include <iostream>
#include <string>
using namespace std;

class Races
{
public:
	int raceID;
	string raceName;
	string raceEner;
	string raceEP;
	string raceDesc;
	float raceAttG[4];
	float raceResE[3];
	float raceResP[3];
	float raceResM[3];

	Races ();
	void raceInfo (int iValue, string sString[4], float dValue[13])
	{
		raceID = iValue;
	    raceName = sString[0];
	    raceEner = sString[1];
	    raceEP = sString[2];
	    raceDesc = sString[3];
		raceAttG[0] = dValue[0];
		raceAttG[1] = dValue[1];
		raceAttG[2] = dValue[2];
		raceAttG[3] = dValue[3];
	    raceResE[0] = dValue[4];
		raceResE[1] = dValue[5];
		raceResE[2] = dValue[6];
	    raceResP[0] = dValue[7];
		raceResP[1] = dValue[8];
		raceResP[2] = dValue[9];
	    raceResM[0] = dValue[10];
		raceResM[1] = dValue[11];
		raceResM[2] = dValue[12];
	}
}DBraces[20], charRace;

int main()
{
	DBraces[1].raceInfo(1, "a", "a", "a", "a", 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5, 1.5);

	return 0;
}

but now it gives a different error

------ Build started: Project: Helios RPG - Beta, Configuration: Release Win32 ------
Compiling...
Main.cpp
.\Main.cpp(44) : error C2660: 'Races::raceInfo' : function does not take 18 arguments
Build log was saved at "file://c:\Documents and Settings\eng\My Documents\Visual Studio 2008\Projects\Project1\Helios RPG - Beta\Helios RPG - Beta\Release\BuildLog.htm"
Helios RPG - Beta - 1 error(s), 0 warning(s)
========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

does it really mean that i can't put 18 arguments? =/