Wiz_Nil

Hi everyone! I hope that u will be able to help me with this small problem.

I got this program that reads characters from a txt file and stores them in a array.
I then want to display the characters but when i do it comes up as squares and funny looking symbols? Why is this, what is wrong with my code?

Your help is greatly appreciated
Many thanks in advance



#include <iostream.h>
#include <fstream.h>

int main()
{
char Name[3][15];

fstream f("a:Names1.dat", ios::in);
if (!f)
cout << "Error opening file";
else {
for (int a = 0; a < 3; a++) {
for (int b = 0; b < 15; b++) {
f >> Name[a][b];
}
cout << endl;
}
}
f.close();

for (int c = 0; c < 15; c++) {
for (int d = 0; d < 15; d++) {
cout << Name[c][d];
}
cout << endl;
}
}

Salem

This is your input loop
for (int a = 0; a < 3; a++) {
for (int b = 0; b < 15; b++) {

This is your output loop
for (int c = 0; c < 15; c++) {
for (int d = 0; d < 15; d++) {

Me-thinks one of those 15's should be 3

Wiz_Nil

Yeh u were right about one of the variable being 3, c was suppose to be 3.

I've changed it but I am still getting funny symbols.
Any ideal why is happening???

Pleaseeee

Salem

Do you have 45 chars in your file?

> f >> Name[a][b];
better check for
f.error() being true, or perhaps f.eof()

> char Name[3][15];
Initialise it to 0, or perhaps fill it with '@' chars before trying to read the file. If it's still got '@' when you print it, then you know something's wrong

minime6696

Well, I noticed that the filename is "a:Names.dat", two thingz,

1.) Thats not a valid filename under win32 platform, are u sure u didnt mean "a:\\Names.dat"? (\\ = escape sequent for '\').

2.) U should post the contents of the file so we can see.

"Crazy Characters" are usually becouse the loading of the file failed, and thats just "garbage" left over in the buffer, just look into the filename thing and stuff...cuz thats prolly the problem!

SPH

Wiz_Nil

I'm putting aside the problem above and working on a similar problem that is related to the above problem slightly.


#include <iostream.h>
#include <fstream.h>
#include <conio.h>
#include <ctype.h>

int main()
{
char Name[3][15];

fstream f("a:abc.dat", ios::in);

if (!f)
cout << "Error opening file";
else
{
for (int a = 0; a < 3; a++) {
for (int b = 0; b < 15; b++) {

f >> getline(Name[a][b], 24, ' ');
}
cout << endl;
}
}
f.close();
}



What I'm trying to do is read characters from a file and store them into an array.

There is something wrong with my code though, it doesn't work.
Can you help, is it an syntax or is the code just screwed up !!!!
Your help is appreciated

Magos

Are you sure its a txt file you're opening? Most of the time when those squares and "funny characters" show up is when you open a binary file as text.

__________________
MagosX.com

Give a man a fish and you feed him for a day.
Teach a man to fish and you feed him for a lifetime.

Wiz_Nil

I think it is as a text file. I'm pretty sure it is.

And the file that it is reading from has the extension .dat but is save as a text file in notepad.

Is this OK?

swoopy

Maybe this:

if (!f)
cout << "Error opening file";
else
{
for (int a = 0; a < 3; a++) {

f >> getline(Name[a], 15);
}