Thread: What is wrong with this 2d array?

The goal is to print a array w/either "1" , nothing " ", but I'm trying to make it into and If statement so it will do one or the other not both......becuase regardless of what the file says is always prints the array w/1's and spaces even when the file is all 2's or all 1's or nothing :?

So I'm kind of lost and yes this was intended as a part of my turtle assignment thing, but more as a test to see if i could get the 2d array to actually work and well I'm not having success

Code:

#include <cstdlib>
#include <iostream>
#include <fstream>
#include <iomanip>

using namespace std;

const int SIZE = 30;
const int SIZE2 = 30; 
void checkPen(int);
void checkPen2(int);
int main()
{
    ifstream infile;
    int fileInput[SIZE][SIZE2], 
        position;
    
    infile.open("turtle.dat");
    
   infile >> fileInput[SIZE][SIZE2];
   for (int i =0; i < SIZE; i++){
       for(int j =0; j < SIZE2; j++){ 
    if (fileInput[SIZE][SIZE2] = 1){
       checkPen(position);
       }
        if (fileInput[SIZE][SIZE2] = 2){
       checkPen2(position);
       }
       }
       }
    system("PAUSE");
    return EXIT_SUCCESS;
}

void checkPen(int position){
     cout << "1";
   
     }
void checkPen2(int position){
     cout << " ";
     
     }

so if i change the

Code:

if (fileInput[SIZE][SIZE2] = 1){
       checkPen(position);
       }

Code:

if (fileInput[SIZE][SIZE2] ==1){
       checkPen(position);
       }

it should work:?....

I'm a littl lost but somewhat get what you are saying about checking if something is false, but could you write a piece of example code showing this with the code I provided :?

You are consistently accessing memory outside of your array. Your array is defined as:

Code:

int fileInput[SIZE][SIZE2]

which means that you can access up to

Code:

fileInput[SIZE-1][SIZE2-1]

Also in your loop you have:

Code:

if (fileInput[SIZE][SIZE2] = 1){
       checkPen(position);
}

Don't you mean for that to be the following?

Code:

if (fileInput[i][j] == 1){
       checkPen(position);
}

well what u put seems to make some sense to me...and after i tried modifying the code I got:

111111111111 Press any key to continue . . .

for output instead of:
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111111111111111111111111111111111 111111111111111111111111111111
11111111111111111111Press any key to continue . . .

but thats with the file reading : 1 2 2 2 1 1 2 and well it should just print: "1 11 "
shouldn't it:?...or something wrong with my loop in the way it read the file x amount of times:?

Is your code to load the 2D array from the file still the same as it is up above? Because that won't work.

Here's a example on how to read integers from a file:

Code:

int i;
while(infile >> i)
    cout << "Read integer: " << i << endl;

Now you could expand that to:

Code:

int i;
while(infile >> i)
{
    fileInput[x][y] = i;
}