C++ problem with Shape hierarchy ~

Code:

#ifndef SHAPE_H
#define SHAPE_H

#include <string.h>
using std::string;

using namespace std;



class Shape

{
public:
	Shape(const string &color); //constructor
	~Shape();
	string getColor()const; //returns objects color value
	virtual double area()const = 0;// a const pure virtual member function that computes and returns the object's area
	virtual string toString() const = 0; //a const pure virtual member function that returns the shape's description
private:
	string s_color;

};


#endif //SHAPE_H

#include <string>
using std::string;

#include <sstream>

#include <iostream>
using std::cout;
using std::cin;
using std::endl;

#include "square.h"

//ctor
square::square(const string &color, double length)
:Shape(color)
{
	length = len;
}//end ctor

//dtor
double square::getLength()
{
	return len;
}
//Function to calculate are
double square::area()const
{
	return len * len;
}//end function to calculate area

//Function to returns square's description
string square::toString()const
{
  ostringstream os;
  os << getColor() <<"square with side length of " << len << " " << "and area of " << area();
  return os.str();

}//end of function to return's square description

#include <string>
using std::string;

#include <sstream>

#include <iostream>
using std::cout;
using std::cin;
using std::endl;

#include "rectangle.h"

//ctor
rectangle::rectangle(const string &color, double width, double length)
:Shape(color)
{
length = len;
wid = width;
}//end ctor

//dtor
double rectangle::getWidth()
{
	return wid;
}

double rectangle::getLength()
{
	return len;
}
//function to calculate rectangle area
double rectangle::area() const
{
	return len * wid;
}//end function to get rectangle area

//returns rectangle's description
string rectangle::toString()const
{
  ostringstream os;
  os << getColor() <<"rectangle with length of " << len << " and width of " << wid << " and area of " << area();
  return os.str();
}//end function to return rectangle's description


#include <string>
using std::string;

#include <sstream>

#include <iostream>
using std::cout;
using std::cin;
using std::endl;

#include "circle.h"

//ctor
circle::circle(const string& color, double radius)
:Shape(color)
{
	radius = rad;
}//end ctor

double circle::getRadius()
{
	return rad;
}
//function to calculate circle area
double circle::area()const
{
	return rad * rad * 3.14;
}//end function to get circle area

//returns circle description
string circle::toString()const
{
  ostringstream os;
  os << getColor() <<" circle with radius of " << rad << " and area of " << area();
  return os.str();
}//end function to return circle description


#include <string>
using std::string;

#include <iostream>
using std::cout;
using std::cin;
using std::endl;

#include "circle.h"
#include "rectangle.h"
#include "square.h"


Shape* getShape()
{	


	int i;
	string shapetype;
	char choice;

	Shape* myShape[6];
	
	
	

	cout << "Creating a Shape  ";
	cout << "============================================== "<<endl;
	cout << " 1: Create a circle "<<endl;
	cout << " 2: Create a rectangle "<<endl;
	cout << " 3: Create a square "<<endl;
	cout << " 4: Done "<<endl;
	cout << "============================================== "<<endl;
	for ( i = 0; i < 6; ++i){
	cout << "Enter number for shapetype" <<endl;

	switch(choice){
	
	case '1':
	cout << "\nEnter the shape's color (or 'done')...";
	cin >>  s_color   ;
	cout << "\nEnter shape type..." ;
	cin >> shapetype;
	cout << "\nEnter radius.... ";
	cin >> radius;
	myShape[i] = new circle(color, radius);
	break;
	
	case '2':
	cout << "\nEnter the shape's color (or 'done')...";
	cin >> color;
	cout << "\nEnter shape type...";
	cin >> shapetype;
	cout << "\nEnter the length and width....  ";
	cin >> width >> length;
	myShape[i] = new rectangle(color, length, width); 
	break;
	
	case '3':
	cout << "\nEnter the shape's color (or 'done')...";
	cin >> color;
	cout <<"\nEnter shape type...";
	cin >> shapetype;
	cout << "\nEnter the length of a side...";
	cin >> length;
	myShape[i] = new square(color, length);
	break;
	
	case '4':
	cout <<"\nEnter the shape's color (or 'done')....";
	cout << "done"<< endl;}

	}
	return myShape[i];

}

For some reason when i try to call the getShape function in main, it doesn't work. the toString function doesnt work neither.

Define "doesn't work". Doesn't compile? Doesn't do what you want?

Originally Posted by tabstop

Define "doesn't work". Doesn't compile? Doesn't do what you want?

It does compile with no errors but when i run the program, nothing comes up. It is suppose to get the shape, the color, and the dimension(size) of the shape. then print the information out.

Once that is done, it is suppose to sort the area.

Since getShape creates shapes and then throws them away and returns a pointer-to-nothing-in-particular-but-especially-not-the-created-shapes, that is perhaps not very surprising.

Remember, arrays can not be returned. I would suggest putting the big ol' Loop Of Asking in your main program and have getshape just make one shape and return it. (You could ask the question in main and pass the user's answer into the function, say.) (Edit: Alternatively, you could pass the array into the function to be filled.)

Originally Posted by tabstop

Since getShape creates shapes and then throws them away and returns a pointer-to-nothing-in-particular-but-especially-not-the-created-shapes, that is perhaps not very surprising.

Remember, arrays can not be returned. I would suggest putting the big ol' Loop Of Asking in your main program and have getshape just make one shape and return it. (You could ask the question in main and pass the user's answer into the function, say.) (Edit: Alternatively, you could pass the array into the function to be filled.)

you mean something like this:

Code:

cout << creating a shape <<endl; 
....

....

for (i = 0; i < 6; ++i){
cout << "Enter number to create Shape" << endl;

getShape();}

??
But the thing is, the guy said the loop should be in the getShape function. and the main function is supposed to call the getShape function and toString function to print out info.

You can leave the loop in the getShape function, but since the array cannot be returned from there, it must be passed in.

getLength and getWidth should be const functions, and don't write an empty, non-virtual destructor. If you don't need to implement or override it, then it's just extra clutter.

You could learn about vectors and return a vector<shape*> from getShape. Then you're code could work.

Originally Posted by iMalc

getLength and getWidth should be const functions, and don't write an empty, non-virtual destructor. If you don't need to implement or override it, then it's just extra clutter.

You could learn about vectors and return a vector<shape*> from getShape. Then you're code could work.

I can't use vector. thing is everytime i call the function in main, it comes up blank even though there is no error in the source(or at least i think).

Are you saying that you're not seeing the input prompts from getShape at all? Post your main() function and/or whatever calls getShape.

Also, tabstop was right both times that you can't return a local array from getShape. Either pass in the array, or allocate it with new inside of getShape and return it.

Originally Posted by medievalelks

Are you saying that you're not seeing the input prompts from getShape at all? Post your main() function and/or whatever calls getShape.

Also, tabstop was right both times that you can't return a local array from getShape. Either pass in the array, or allocate it with new inside of getShape and return it.

It's' suppose to return a base Shape* to the new object. I called like i declared it in getShape cpp, shape* getShape*(); it compiles but nothings comes on the screen

My mistake - you're already returning something allocated with new (a Shape *). Can you show us the exact code snippet where getShape() is called?

Originally Posted by medievalelks

My mistake - you're already returning something allocated with new (a Shape *). Can you show us the exact code snippet where getShape() is called?

Shape* getShape(); thats how i called it

That's a function declaration, not a function call. Post your main() function that alledgedly calls getShape().

Originally Posted by medievalelks

That's a function declaration, not a function call. Post your main() function that alledgedly calls getShape().

i called it like this:

Code:

int main();
{
Shape getShape();
Shape::toString();
}

Originally Posted by jackfraust

i called it like this:

Code:

int main();
{
Shape getShape();
Shape::toString();
}

Is this function static?
Don't you need an object of type Shape?

Code:

Shape objShape;
objShape.toString();