Data is lost somewhere ...

Hi, i have three classes

1. Rental.H

Code:

/* All my includes */ 
....

class Driver;

class Rental
{

public:

	Rental(Driver& d);
	~Rental();

        ....

	....

        void CreateNewContract();

	....

        ....

private:

	Driver& driver;

};

#endif

2. Driver.H

Code:

/* All my includes */ 
....


class Driver						
{
public:
	Driver();

       ....

	void SetAddress(const Address& add);
	Address getAddress() const;

       ....

private:

       ....

	Address address;

       ....
};

3. Address.H

.....

.....

I then use them in Rental.cpp

Code:

void Rental::ReadNewAddress()
{
       /* Declare variables & read data from use */
      
      .....

      .....


        /* Here' my Problem */
	driver.getAddress().SetAddress(fline, sline, sbb, city, cde);
}

As you noticed, address object is a member to driver, i initialize it as you can see above ... But after this line the address object is always empty ... The function SetAddress() works well cause i used Debug to check if all its members ...

Code:

	std::string firstLine;
	std::string secondLine;
	std::string thirdLine;
	std::string city;
	std::string code;

were set properly ... Is there any other way to do this except driver.getAddress().SetAddress()?

You are apparently setting the address of a temporary Address returned by Driver::GetAddress.

There are other things I don't understand in the code. Why does Rental have a reference to Driver? This means that a Rental cannot exist without a Driver, and a Rental must refer to the same one and only Driver its entire lifetime. I would have thought that a Rental can exist without anything being rented out at the moment...

Or why is a Rental trying to change the Address of a Driver in the first place?...

Originally Posted by anon

You are apparently setting the address of a temporary Address returned by Driver::GetAddress.

There are other things I don't understand in the code. Why does Rental have a reference to Driver? This means that a Rental cannot exist without a Driver, and a Rental must refer to the same one and only Driver its entire lifetime. I would have thought that a Rental can exist without anything being rented out at the moment...

Mhh.. true! i will try to fix that ...

Or why is a Rental trying to change the Address of a Driver in the first place?

On an new contract, there's a function which request data from user including the driver details which includes his/her address ... All this is done on new contract reason its done inside the Rental.cpp

Code:

/* Here' my Problem */
	driver.getAddress().SetAddress(fline, sline, sbb, city, cde);

driver.getAddress() returns an address, but then you are trying to call SetAddress on this returned Address. You don't have a SetAddress function in the Address class, at least that you showed. And the parameters you are passing to SetAddress don't match the function declaration that you showed.

Originally Posted by DaveH

driver.getAddress() returns an address, but then you are trying to call SetAddress on this returned Address. You don't have a SetAddress function in the Address class, at least that you showed. And the parameters you are passing to SetAddress don't match the function declaration that you showed.

I do ...

Address.H

Code:

#include <string>
#include <fstream>

class Address						
{
public:
	Address() {};

	Address(const std::string& firstLine, const std::string& secondLine, const std::string& surbub, 
		const std::string& city, const std::string& code);
	void SetAddress(const std::string& firstLine, const std::string& secondLine, const std::string& surbub, 
		const std::string& city, const std::string& code);
	
	friend std::istream& operator>>(std::istream& in, Address& address);
	friend std::ostream& operator<<(std::ostream& out, const Address& address);

	bool ReadFromFile(std::istream& indata);
	const std::string& getFirstLine() const;
	const std::string& getSecondLine() const;
	const std::string& getThirdLine() const;
	const std::string& getCity() const;
	const std::string& getCode() const;
private:
	std::string firstLine;
	std::string secondLine;
	std::string thirdLine;
	std::string city;
	std::string code;
};

But it seems silly that you do it this way...
It seems more natural or better syntactically to call setAddress on Driver with a newly initialized (temporary) Address object.

Originally Posted by Elysia

But it seems silly that you do it this way...
It seems more natural or better syntactically to call setAddress on Driver with a newly initialized (temporary) Address object.

Like this?

Code:

Address Driver::getAddress(const std::string& fline, const std::string& sline, const std::string& tline,  const std::string& cty, const std::string& cde, Address add)
{
	add.SetAddress(fline, sline, sbb, city, cde);

	return add;
}

No, I mean like:

Code:

driver.setAddress( Address(...) );

Originally Posted by Elysia

No, I mean like:

Code:

driver.setAddress( Address(...) );

Oh you mean through a constructor ...

Happy New Year BTW!!!!!

Originally Posted by Elysia

No, I mean like:

Code:

driver.setAddress( Address(...) );

A question, where should this be done? Address object is not in Rental class... And if i'm doing it inside Driver.cpp, then shouldn't this be good enough?

Code:

void Driver::setAddress(const std::string& fline, const std::string& sline, const std::string& tline, 
				const std::string& cty, const std::string& cde)
{
	address.setAddress(fline, sline, sbb, city, cde); /* EDITED */
}

address being a private member of Driver class...

I mean that wherever you do:

Code:

driver.getAddress().SetAddress(fline, sline, sbb, city, cde);

...you instead do...

Code:

driver.SetAddress( Address(fline, sline, sbb, city, cde) );

Address is a stand-alone class that encapsulates a date.
And GetAddress should probably return a const reference to the internal Address structure. That is typically how it is done, I think.
It seems more natural, too.