Thread: pow command

What happens when you compile and and run this code?

Code:

#include <iostream>
#include <cmath>

int main(){
  for(int x=1;x<21;x++){
    int y = pow(x,2);
    std::cout << y << std::endl;
  }
}

You should definitely be getting the square numbers from 1 to 400.

Originally Posted by whiterebbit

But why does my code produce 1 less for 5^2 and for all multiples of 5 eg 5^2=24 and 10^2=99.

Such a bug could be due to floating point inaccuracy. A possible fix could be to add some small value to the result of pow() before converting back to int, e.g.,

Code:

int y = static_cast<int>(pow(x, 2) + 0.0001);

Of course, you really should just use x * x instead of pow()

By the way, you might want to indent your code properly and remove the #include <stdio.h> since you do not use it. <math.h> should also be <cmath> since the former is the C version of the C++ standard header. Oh, and I note that you actually have two variables named y: one exists directly in the scope of the main() function while the other exists in the scope of the for loop. You probably only want to keep the one that exists in the scope of the for loop.

To paraphrase the C++ standard: the result of the expression static_cast<T>(expr) is the result of converting the expression expr to type T, except that some kinds of type conversions are not allowed, e.g., casting away const-ness.

By the way, the expression should be:

Code:

int y = static_cast<int>(pow(x, 2.0) + 0.0001);

The 2.0 is important since std::pow() is overloaded but none of the overloads match int. Therefore, you need to use 2.0 instead of 2 so that the overload for double is matched. You might not face this with the C header <math.h> since the overloads would only come into play for the C++ header <cmath>.

Originally Posted by whiterebbit

Secondly sorry I'm new could you please explain the rules for indenting code.

Everytime the code is nested increase the indent level by 1, and everytime it leaves the nesting decrease the indent level by 1. Be consistent with your indentation and choose a consistent brace placement policy. For example:

Code:

int main()
{
    bool x = true;
    if (x)
    {
        while (x)
        {
            // ...
        }
    }
    else
    {
        // ...
    }
}

Note however that using pow(x, 2.0) to square a integer number is like using a lorry to do your weekly shopping - using x * x will be MUCH simpler for the computer to do the calculation, with the added advantage of it being precise.

--
Mats

Indentation article on cpwiki: cpwiki.sf.net/Indentation

(I must say that cpwiki is more alive than I thought it would be after all this time! )