clock

[And3rs]

I want to make a clock in realtime, but every time I print out a new time it never updates, how come?

Timer.h

#ifndef _TIMER_
#define _TIMER_

#include <ctime>


class Timer {
    clock_t counter;
public:
    Timer(): counter(0) {};

    bool elasped(clock_t ms)
    {
        clock_t tick = std::clock();

        if(tick - counter >= ms)
        {
           counter = tick;
    return true;
		}
		return false;
	}
};
#endif

main.cpp file

int main()
{
	Timer timer;
	time_t now;
	time(&now);

	while(true)
	{
		if(timer.elasped(1000))
			cout << ctime(&now);
	}
}

[scwizzo]

You're never updating the variable now inside the while loop. Do something like...

	while(true)
	{
                time(&now);
		if(timer.elasped(1000))
			cout << ctime(&now);
	}

[And3rs]

What exactly did time(&now) do in the while(true) ??

because it works.

Thx scwizzo

[scwizzo]

ctime() just converts a time that was already retrieved to a string. time() retrieves that time. So essentially you were retrieving the time once, then printing the same thing over and over. Putting it in the while loop makes it gather a new time every pass of printing it.

[laserlight]

Update the variable now, as scwizzo noted you did not do.

[And3rs]

Aaah I see, thanks for all the answers =)

[matsp]

You probably want to:
1. Update now AFTER the time has elapsed.
2. Spell elaPSed correctly.
3. Use CLOCKS_PER_SEC to calculate milliseconds, as "clock()" may return something that isn't milliseconds.

Further, if you want to wait for a second, you should probably not "eat" all the CPU time for that period of time. Sleep() in Windows will wait for a specific number of milliseconds, and usleep() in Linux/Unix will wait for a specific number of microseconds.

--
Mats

[And3rs]

aight matsp.

but try for yourself with the spelling thingy.

when printing out timer. the compiler suggest elasped, so.. not my fault ;D

[matsp]

aight matsp.

but try for yourself with the spelling thingy.

when printing out timer. the compiler suggest elasped, so.. not my fault ;D

That's because elasped is defined with the wrong name in the timer class itself. Fix that, and it should fix the rest.

I know my spelling is not perfect (mostly because my fingers do not do what I think they are doing), but having incorrect spelling for names in your program just makes it really annoying, because I would write "timer.elapsed", and then wonder why I get a compiler error.

--
Mats

[And3rs]

Ah yeah, I saw where my typo was now.

Thanks for the correction