Linked List Problems

I mean:

Code:

#include <list>

In addition to the other header files that you already need.

EDIT:
At a glance, one objection I have to Nor's suggested class design is that the std::list<Song>::iterator named Iter should not be a member variable. It should be a local variable of whatever member function needs such an iterator.

EDIT #2:
Oh, and isfull(), getTotalMemory(), getRemainingMemory() and the overloaded operator<< are all not const-correct. The member functions should be declared const, and the overloaded operator<< should take the Song by const reference.

where can I declare

Code:

int totalMemory = 0;
    int usedMemory = 0;
    int currentSize = 0;

in the .h or the cpp ? in the constructor or before? private or public? should I make the static const? I didnot think that was the answer but Im not sure anymore? everywhere I think I should put it, it tells me it either forbids initiallization or they are undeclared.

I gotta go run an errand...I appreciate all the help really...I am trying to learn and understand this stuff. Will any of you be back this afternoon or tomorrow? Thanks so much again

I emailed my professor earlier. She says we can not use std::list<>...
Back to the drawing board

If i was you. Coffee Coffee Coffee
Your code is on the right track but i can't wright it for you.
You just need to do a lot of error checking in your code.
I understand why your instructor is forcing you to create a linked list.

Try writing just the list code first. And always make sure it can compile. between you writing portions of code. Even if it doensn't work. Make it Compile. this will find the simple syntax error your making.
get your list working Then try getting fancy. There are lots of implementations out there.
Just remember - plagiarism is wrong. Get help but don't cheat.

I think I am getting it...maybe...
how do I get information from my class into my linked list?
I have

Code:

int BobCatPod::getTotalMemory()
{
    totalMemory = s.size;
    return totalMemory;
}

where s is an instance of class Song and size is a variable of s. I need to say that the totalMemory is equal to the size in an instance of the class. and return that size.

Ok I have everything put together and my files compile, but I am getting an error in the poddriver which was given to us. Here is what I have...the error i am getting is no matching function for call to BobCatPod::BobCatPod(int)
in line 19 of the poddriver file. thanks

Code:

// poddriver.cpp

//Adapted from Roger Priebe
//CS2308 11/17/08

#include <stdlib.h>
#include <iostream>
#include "BobCatPod.h"

using namespace std;

int main()
{
    
    Song s1("Frank Sinatra", "My way", 14);
    Song s2("Beatles", "Act Naturally", 5);
    Song s3;
    
    BobCatPod p(256);
    BobCatPod q(512);
    BobCatPod r(25);

    cout << "pod p" << endl << p << endl;
    cout << "pod q, size 512 exceeds max, should be reset to 256 " << endl
         << q << endl;
    cout << "pod r, size should be 25 " << endl << r << endl;


    cout << "Song 1" << s1 << endl;
    cout << "Song 2" << s2 << endl;
    cout << "Song 3" << s3 << endl;

    s3.setArtist("Buck Owens");
    s3.setTitle("Act Naturally");
    s3.setSize(20);

    cout << "Song 3 updated " << s3 << endl;
    cout << "Artist 1 (Frank Sinatra)  " << s1.getArtist() << endl;
    cout << "Title 2 (Act Naturally)  " << s2.getTitle() << endl;
//    s1.setSize(7);
//    cout << "Size 1 (7) " << s1.getSize() << endl;

//test relational operators

    if (s1 < s3 ) cout << endl << "s1 < s3" << endl;
      else cout << endl << "s1 >= s3" << endl;
    if (s1 == s2) cout << endl << "s1 == s2" << endl;
      else cout << endl << "s1 != s2"  << endl;
    
// test addnode
    cout << "add song 1, size 14 " << r.addSong(s1) << endl;  
    cout << "   memory left = "  << r.getRemainingMemory() <<endl;
    cout << "add song 2, size 5 " << r.addSong(s2)<< endl; 
    cout << "   memory left = "  << r.getRemainingMemory() << endl;
    cout << "add song 3, size 20 should fail " << r.addSong(s3) <<endl;
    cout << "   memory left = "  << r.getRemainingMemory() << endl;
  
    s3.setSize(2);
    cout << "Size 3 (2) " << s3.getSize() << endl;
    cout << "add song 3, size 2 should succeed " << r.addSong(s3) 
         << "   memory left = "  << r.getRemainingMemory() << endl;


// test output
    cout << r << endl;

//test delete

    r.removeSong(s1);
    cout << r << endl;
    r.removeSong(s3);
    cout << r << endl;

    cout << "Total Memory = "<< r.getTotalMemory() << endl;





    return 0;
}

Code:

//song.h
#ifndef SONG_H
#define SONG_H
#include <stdlib.h>
#include <iostream>
#include <ostream>
#include <string>
#include "BobCatPod.h"
using namespace std;


class Song
{
  
   public:
      Song();
      Song(string , string , int ); // constructor
      void setSize(int s);
      int getSize(); // access or
      void setTitle (string t);
      string getTitle();
      void setArtist (string a);
      string getArtist();
      void addSong (int);
      friend ostream& operator<<(ostream & os, Song & s);
   private:
      string title;    //dynamic allocation
      string artist;
      int size;
};
#endif

Code:

// file song.cpp
#include "song.h"
#include "BobCatPod.h"

 ostream & operator << ( ostream & os, Song & s)
 {
      os << s.getTitle();
      os  << s.getArtist();
      os << s.getSize();
      return os;
 }
//constructor
Song::Song ()
{
    title=" ";
    artist=" ";
    size = 0;
}
Song::Song(string a, string t, int s) // constructor
{
    size = s;
    title = t;
    
    artist = a ;
    
}
//accessor for name
string Song :: getTitle()
{
      return title;
}
//mutator
void Song :: setTitle (string t)
{
     title = t;
     
}
string Song :: getArtist()
{
      return artist;
}
//mutator
void Song :: setArtist (string a)
{
     artist = a;
     
}
void Song::setSize(int s)
{
    size = s;
}
int Song::getSize()
{
    return size;
}

Code:

//BobCatPod.h

//Specification files for the SongList class

#ifndef BOBCATPOD_H
#define BOBCATPOD_H
#include "song.h"



class BobCatPod
{
      
      private:
      struct SongNode
      {
             Song s;                  //value in this node
             SongNode *next;
      
                         
      };
      
      SongNode *head;
      static const int MAX_MEMORY = 256;
      
      
      public:
             int totalMemory;
             int remainingMemory;
             
             
             //Constructor
             BobCatPod();

                 
             //Linked list operations
             
             bool isFull ( ) const;
             int addSong (Song s);
             int removeSong (Song s);
             void showSongList ();
             int getTotalMemory();
             int getRemainingMemory();
             friend ostream& operator<<(ostream & os, Song & s);
             
             //Destructor
             ~BobCatPod();

};
#endif

Code:

//BobCatPod.cpp
#include "song.h"
#include "BobCatPod.h"



BobCatPod::BobCatPod()
{
     head = NULL;
     
}

bool BobCatPod::isFull ( ) const
{
     if (totalMemory > MAX_MEMORY)
     {
      
                return true;
     }
}


int BobCatPod::addSong(Song t)
{
      if (isFull ())
     {
                return 0;
     }
     SongNode *newSong = new SongNode;     //a new node
     
    
     
     // Allocate a new node and stor num there.
     
     newSong->s = t; 
     head = newSong;
     newSong->next = NULL;
     totalMemory++;
    
     return 1;
}


int BobCatPod::removeSong( Song t )
{
     if (isFull ())
     {
                totalMemory--;
                return 1;
     }
     else     
     return 1;
}
 
void BobCatPod::showSongList( )
{
     SongNode *n;
     cout<<endl;
 
     for( n = head ; n != NULL ; n = n->next )
        cout<<endl<<n->s;
}

int BobCatPod::getTotalMemory()
{
    Song t;
    totalMemory = t.getSize();
    return totalMemory;
}

int BobCatPod::getRemainingMemory()
{
    
    remainingMemory = MAX_MEMORY - totalMemory;
    return remainingMemory;
}

thanks again

The reason for this error is you have not made a constructor for BobCatPod that takes an int.
What is the int argument for?

Code:

BobCatPod::BobCatPod(int i);//In your header file

BobCatPod::BobCatPod(int i)  //This goes in your cpp file
{
    //I'm guessing this is how much memory your pod has.
    if( i <= MAX_MEMORY)
        remainingMemory = i;    
    else
        remainingMemory = MAX_MEMORY;//The assignment only allows 256. No more.
}

good luck.

ok just one more question about overloading operators.
If I have included

Code:

friend ostream& operator<<(ostream & os, Song & s);

in my .h files why do i get the error no match for 'operator <<' in '(std:perator<<?
why does it need another overload?

It does not need another overload. The problem is that you should be passing the Song by const reference:

Code:

friend ostream& operator<<(ostream & os, const Song & s);

I tried that

Code:

friend ostream& operator<<(ostream & os, const Song & s);

in my .h instead of the

Code:

friend ostream& operator<<(ostream & os, Song & s);

but I get the same error.

Ok I think I only have one more problem.

In my .h I have

Code:

friend ostream & operator<<(ostream & os, const Song & s);

and in my cpp

Code:

ostream & operator << ( ostream & os, Song & s)
 {
      os << s.getTotalMemory();
      os  << s.getRemainingMemory();
      return os;
 }

and I need it for

Code:

 BobCatPod p(256);
    BobCatPod q(512);
    BobCatPod r(25);


    cout << "pod p" << endl << p << endl;

but it doesn't work. Why the error says no match for 'operator<<'

BobCatPod and Song appear to be two different classes. Also, note that your function declaration (prototype) should match the function definition (const Song& s in both cases).

You guys have been great. I now have everything compiling, but I can't get it to run. I keep getting a linker error? I don't know why it doesn't link I have all my files included I think. What would make it do this? what should I check? Thanks

Originally Posted by Nor

Code:

     newNode = new SongNode;
     newNode->s = num;//<<<<<NEVER use new memory without error checking.

Why not? new is guaranteed to return a valid object unless you are using nothrow. If the allocation fails an exception is thrown.