Read and write binary file?

Hi all, I am trying to write a struct to a file then read it again, but it cant get it to work. It compiles file, but when I try to read it, I don’t get anything. I don’t think that I am writing the data to the file correctly. Because when I have a look at the file I am writing to with a hex editor I get this.

Code:

f4 24 3d 00 14 25 3d 00 00                 ô$=

Below is the code, anyideas on what I am doing wrong?

Code:

#include <cstdlib>
#include <iostream>
#include <fstream>

using namespace std;

struct ITEM {
       string txta;
       string txtb;
       } item;
int main(int argc, char *argv[])
{
    item.txta = "txta";
    item.txtb = "txtb";
    cout << item.txta << " = " << item.txtb << endl;
    ofstream fout("file.dat", ios::binary);
    fout.write((char *)(&item), sizeof(item));
    fout.close();
    item.txta = "";
    item.txtb = "";
    ifstream fin ("file.dat");
    if (fin.is_open())
    {
        while (! fin.eof() )
        {
              fin.read((char *)(&item),sizeof(item)); 
              cout << item.txta << " = " << item.txtb << endl;
        }
    } else cout << "Unable to open file";
    return EXIT_SUCCESS;
}

You never include <string>. Works fine for me once I do that.

Storing strings in a file as a binary object is not going to work in the long term. You need to use some other method to store the strings than to just copy the object itself.

A string class may look a bit like this (much simplified):

Code:

class string
{
 private:
    char *buffer;
    size_t len;
 public:
    string(const char *str) 
    { 
       len = strlen(str); 
       buffer = new char[len]; 
       memcpy(buffer, str, len);
    }
}

Now, if you save that class to disk, you are going to save 8 bytes [in a 32-bit OS]: The buffer pointer and the length. The pointer is 100% sure to not point to the same string when you load it back in again [at least if you exit the application and start it again - and the ability to get the data back after exiting the application is USUALLY why we save data to a file].

You need to store the string itself, which is what buffer in this case is pointing at.

As to the best way of doing that in a binary file... That is a $64000 question, really - it would depend on what type of text you are storing, how much variation you expect in the sizes, how many items you expect to have, whether space or ease of programming has higher priority, etc, etc.

--
Mats