Problem with the control characters

dear all,

one strange behaviour i have seen in my program that the program works fine for the control characters means it reads the files properly,but when i remove the control characters from my file some data get lost from that file while reading what can be reason,
any suggestions please.

I'd guess it still means there are bugs in your code.

Did you switch from reading in binary mode to reading in text mode?

Post your code, not a description.

dear experts thank you for the reply,

here is the piece of code that i am trying to do

Code:

fpFile = fopen(filename,"rb");//here filename is "test.csv"
if (fpFile != NULL)
{
char buf[SizeValue];//here SizeValue is the size of the file for that i am using separat function to find out .
fread(buf, 1, SizeValue , fpFile);
strcat(buf,"\0");

getMstringVector(buf, '\n', *svect);//which converts from buffer to a vector svect
int scount = svect->getCount();//which gives nummber of lines 
for(int i = 0; i < scount-1; ++i)
  {
if((*svect)[i].indexOf('\r')) //which checks for control characters
{ 
(*svect)[i].replace('\r','\0');
	
}
   getMstringVector((*svect)[i], ",", *tvect);//which converts each line based on delimeters(,) to a vector tvect

int tcount = tvect->getCount();
if( tcount > 0)
{
  for(int j = 0; j < tcount; ++j)
    {
     char *tvect1;
     tvect1 = (char*)(*tvect)[j];
     char *str2 = strtok(tvect1, search_str);
       while(str2)
       {
		   
        int length = strlen(str2);
        char *mystr = 0;
         mystr = new Mbyte[length];
        strcpy(mystr, str2);
       str2 = strtok(NULL, search_str);
        like this the code follows this is the main snippet
}
}
}
}

so this works fine with the file with control characters but not for the file without control characters
please some suggestion.

It looks like you don't allocate enough memory for the null-terminator in your strings. You need strlen(x) + 1 bytes to store the string x.

As it is C++, you might also be better off using strings and vectors.

Dear experts,
please tell me is there any way to split the given string based on delimeters apart from using strtok() function, please tell me because i think there is a problem with that only.

One way would be to use boost's string algorithms library:

Code:

#include <iostream>
#include <string>
#include <vector>
#include <boost/algorithm/string.hpp>

int main()
{
    std::string s("first,second,third\nfourth,and last");
    std::cout << s << "\n\n";
    std::vector<std::string> vec;
    boost::split(vec, s, boost::is_any_of(",\n"));
    for (unsigned i = 0; i != vec.size(); ++i) {
        std::cout << "'" << vec[i] << "'" << '\n';
    }
}

Another way might be to read the file with getline and then use a stringstream and another form of getline to split each line at commas.

If you have a file of comma-separated values, then I don't see why you should read it in binary mode and why you should be so much worried about control characters. On the other hand, there are escape sequences (quoted strings?) which means that simply splitting the file contents at commas and newlines won't necessarily produce the correct results.

Code:

strcat(buf,"\0");

is absolutely pointless - it will insert a zero at the end of the string, which is already indicated by a zero. If there is no zero at the end of the string in the first place, strcat will go beyond the end of the actual string variable, and the zero will be put in the place where the first zero appears in memory (unless it crashes first).

Generally, fread is not great for reading text files, and it doesn't put a zero on the end of the buffer. fgets reads a line, which is great for text files.

A .csv file is a text file, so there is no need to open it as a binary file, nor does it make any sense to replace '\r' with '\0' in that case, since all '\r' would be removed at that point.

--
Mats

dear all,
i have one small question elated to this,

how to print the std::string into the fprintf(),

Code:

for eg:
std::string line;//which contains some data
fprintf(fpfile,"%s",line)

which is giving me a junk value what is the proper way of using this, means i am taking the value of line into the file which is opened for write mode.

That would of course not work, the C function fprintf() has no idea what a C++ std::string is.

You could fix the problem by passing the constant C string, e.g. fprintf(fpfile, "%s", line.c_str()); .

--
Mats

Originally Posted by vin_pll

dear all,
i have one small question elated to this,

how to print the std::string into the fprintf(),

Code:

for eg:
std::string line;//which contains some data
fprintf(fpfile,"%s",line)

which is giving me a junk value what is the proper way of using this, means i am taking the value of line into the file which is opened for write mode.

You can use line.c_str() which return a char* so you can use a std::string in C string fucntions

Another simple string splitting function that I like to use is as follows:

Code:

void StringSplit(const std::string& str, char delim, std::vector<std::string>& v)
{
  std::string token;
  std::stringstream ss;
  ss.str(str);
  while (getline(ss, token, delim))
  {
    v.push_back(token);
  }
}

Originally Posted by Elkvis

Another simple string splitting function that I like to use is as follows:

That is pretty much what anon described as a specific alternative to boost::split, but incidentally,

Code:

std::stringstream ss;
ss.str(str);

can be simplified to:

Code:

std::stringstream ss(str);

and since you are fully qualifying all names in the std namespace, it makes sense to qualify getline() as std::getline() as well.

Originally Posted by laserlight

and since you are fully qualifying all names in the std namespace, it makes sense to qualify getline() as std::getline() as well.

good point. can't believe I missed that. it's interesting to note that with no 'using' statements in my program, getline works with no std:: specifier in front. I'm not exactly sure what to think of that.