naming iterators and other datatypes

[l2u]

If you have more iterators inside one function, how would you call them?

For instance:

std::vector<std::string>::iterator vec_iter;
std::vector<std::string>::iterator vec2_iter;
std::set<std::string>::iterator set_iter;

Or is there any better system to keep short and 'pretty' names?

[laserlight]

What are the iterators for? That would determine what names are appropriate for them.

[l2u]

For looping through the containers.

[laserlight]

For looping through the containers.

Duh, iterating is probably the most common use of iterators. Perhaps you should read Stroustrup's answer to the FAQ How do you name variables? In particular: "Name a variable (function, type, whatever) based on what it is or does. Choose meaningful name; that is, choose names that will help people understand your program."

[Daved]

What does the string inside the vector represent? Is it a name? How about cur_name? If you're using the two iterators at the same time, one might be cur_name and the other prev_name. Or perhaps one is source_name and the other target_name. There is usually information about what the iterators hold besides the fact that they are being used as iterators. I assume your vectors and set are named appropriately? If so, you could incorporate those names into the iterators that come from each of them.

[master5001]

This is where namespaces can shine, though its not necessarily the best use for them:

Example:

namespace mylib
{
  namespace str
  {
    typedef std::vector<std::string> vector;
    typedef std::set<std::string> set;
  }
}

Which affords you the ability to make code like this:

Example:

#include "mylib.h"

using namespace mylib;

int main(void)
{
  str::set::iterator i;
  str::vector:: iterator p;

  return 0;
}

Though maybe that is still too cluttered for your liking... I prefer to keep what the iterator belongs to with its class. Except for within the context of the class.

[King Mir]

Name the iterators based on the containers they point to.

[cpjust]

Name the iterators based on the containers they point to.

Isn't that what he has now? Those names tell me nothing about what they're actually used for.

[King Mir]

No, I mean naming them after the specific instance of the container they are used for. For example if you have a container called friends, listing all the buddies in an IM application, you could use an iterator called "friendIterator" to iterate through the container.