plz help with deleting class deconstructor.

**just realized my topic title makes no sense.. apologize ahead of time.

I'm having a hard time with this code.. plz help me out..

Code:

#include<iostream>
using namespace std;

char input[101];

class NameAdd
{
	char* name;
	char* address;

	public:
		NameAdd()	{
				this->name = "my_name";
				this->address = "my_address";
		}
		~NameAdd()	
		{	
			cout << "Deleting the base!!!" << endl;
			delete this->name; delete this->address;
		}
};

class amountnum : virtual public NameAdd
{
	char* amount;

	public:
		amountnum()	
		{		
				this->amount = "a_amount";
		}
		~amountnum()	
		{
			cout << "Deleting the osap!!!" << endl;
			delete this->amount;
		}
};


int main()
{
	NameAdd * formlist[5];
	int limit = 1;
	formlist[limit] = new amountnum();
	system("pause");
	delete formlist[limit];
	cout << "success!" <<endl;
	system("pause");
        return 0;
}

i know the delete isn't working. i was hoping someone could shine some light as to whats wrong.

Code:

#include<iostream>
using namespace std;

char input[101];

class NameAdd
{
	char* name;
	char* address;

	public:
		NameAdd()	{
				this->name = "my_name";
				this->address = "my_address";
		}
		virtual ~NameAdd()	// Destructor should be virtual in this case
		{	
			cout << "Deleting the base!!!" << endl;
			//delete this->name; delete this->address;   // DON'T. The value name and adress hold weren't allocated with new
		}
};

class amountnum : virtual public NameAdd
{
	char* amount;

	public:
		amountnum()	
		{		
				this->amount = "a_amount";
		}
		~amountnum()	
		{
			cout << "Deleting the osap!!!" << endl;
			//delete this->amount;   // Same thing here
		}
};


int main()
{
	NameAdd * formlist[5];
	int limit = 1;
	formlist[limit] = new amountnum();
	system("pause");
	delete formlist[limit];
	cout << "success!" <<endl;
	system("pause");
        return 0;
}

god bless these forums..
thank you foxman.

You only need to delete what you allocate with new
Btw, you don't need to prefix "this->" when accessing members either. I don't know if you know or not...

Also, unless there's more code that you haven't shown, you probably don't need virtual inheritance when deriving class amountnum. The virtual destructor is enough.

Also, if you would have allocated those strings with new, then you were using the wrong version of delete. To delete dynamic arrays you need to use

Code:

delete [] ptr;

not just

Code:

delete ptr;

Also, never assign string literals to non-const char pointers.

Just use std::string.