Link Error : unresolved external symbol "public: __thiscall"

Ok this is not gonna be a simple one to explain since few classes are involved ... But, i'm goona start with the main class

Code:

---

#include "Fleet.h"
#include "Menu.h"
#include "Rental.h"
#include <conio.h>

using namespace std;

/* ------------------------------------------------------------------------------------------------
* Main
*/
int main()
{
        Fleet fleet;
        Rental rental;

/*** Create and Add Menu Items to the Menu list ***/

        Menu menu(fleet, rental);
        menu.CreateMainMenu();
        menu.CreateFleetMenu();
        menu.StartScreen();
        menu.toFleetMenu(false);

/*** Execute menu until user quits.... ***/
       
        do {
                menu.choose();
        }
        while (!menu.done());

        return 0;
}
/*** ERROR ****/
error LNK2019: unresolved external symbol "public: __thiscall Rental::~Rental(void)" (??1Rental@@QAE@XZ) referenced in function _main
error LNK2019: unresolved external symbol "public: __thiscall Rental::Rental(void)" (??0Rental@@QAE@XZ) referenced in function _main
 : fatal error LNK1120: 2 unresolved externals
*/


---

Class Rental

Code:

---

#include "Contract.h"
#include <vector>

class Driver;

class Rental
{
private:
        typedef std::vector<Contract> RentalContract;
        typedef RentalContract::iterator ContractsIterator;

public:

        Rental();
        Rental(Driver&);
        ~Rental();

        //RentalContract getRental();

        void CreateNewContract();
        void DeleteContract();
        void ViewContract();
        ContractsIterator find();
       
private:
        RentalContract contracts;
        Driver &driver;
};

/** Part of its CPP **/

include "Rental.h"
#include "Driver.h"
#include <iostream>
#include <algorithm>
#include <conio.h>

Rental::Rental(Driver& d) :
driver(d)
{}

---

Let me stop here perhaps you may pick up the fault already ...

You need to compile all your .cpp files together.

My guess is that you forgot to implement the default constructor and destructor of Rental despite declaring them. Since you have a reference member, you would need to implement the Rental default constructor, but it looks like the compiler generated destructor will do.

Quote:

---

Originally Posted by laserlight

My guess is that you forgot to implement the default constructor and destructor of Rental despite declaring them. Since you have a reference member, you would need to implement the Rental default constructor, but it looks like the compiler generated destructor will do.

---

Well i did this Rental::Rental() {} but then i get an error

Code:

---

: error C2758: 'Rental::driver' : must be initialized in constructor base/member initializer list

---

Tried the following to solve the error

Code:

---

Rental::Rental(Driver& d) :
driver(d)
{}

Rental::Rental():
driver()
{}

---

but got this error

Code:

---

: error C2354: 'Rental::driver' : initialization of reference member requires a temporary variable

---

:(

Since driver is a reference, it must be bound to something. If you want to have a Rental without a driver like this, then you can't use references (presumably you meant to have a pointer?).

Solved my problem,

Code:

---

        Driver driver;
        Rental rental(driver);

---

My stupidity really ... /bangs his head hard against the wall ~^*:devil:

driver is a reference, so it must refer to something. You can either choose to change driver to a pointer (or an object, but it may not make sense for a Rental object to own a Driver object), or simply only allow Rental objects to be constructed with a driver (in which case the code of your main() function must change).