Problem: [Linker error] undefined reference to ...

[bigmac(rexdale)]

I's using dev c++ to compile my program and i get a linker error for every class function that main calls.

I included the code for the .cpp and .h files in a .txt file called "code", i also included the .txt file that the program needs to read, "prefixRanges".

Any one know what i did wrong here?

[Salem]

Have you added all the .cpp files to your project?

[bigmac(rexdale)]

Yeah i added everything you'd need to compile it in the code.txt, i probably should've bolded the headers that indicated a new .h or .cpp file

[anon]

I noticed that your Order.cpp forward-declares ISBN and then goes on to use it as if it was fully defined. This shouldn't even compile.

You need to include Isbn.h in Order.cpp instead.

Your headers are also missing header guards (to guard against multiple inclusion from the same compilation unit).

#ifndef ISBN_H
#define ISBN_H

//header contents here
#endif

It is also considered bad style to use using directive in headers (files including that header get the std:: namespace whether they want it or not).

By the way, ISBN's are nowadays 13-digit (not 10-digit) if I'm not mistaken

[bigmac(rexdale)]

made the follwing changes:
order.cpp:

#ifndef Order_H
#define Order_H
#include "Order.h"
#include "ISBN.h"
#endif

isbn.cpp:

#ifndef ISBN_H
#define ISBN_H
#include "ISBN.h"
#include "ISBNPrefix.h"
#endif

isbnprefix.cpp

#ifndef ISBNPrefix_H
#define ISBNPrefix_H
#include "ISBNPrefix.h"
#endif

also changed the class ISBN; in order.cpp

only thing i'm stuck on is the "using directive in headers", don't know what that is exactly

btw, i'm still getting the linker errors....and yes they are 13, but our prof said we'll only be using 10 digits

[anon]

No, header guards go into headers.

Generally it is not recommended to put using namespace ... into headers. You might rather prefix all the few standard things you have there (like ostream) with std:: (std:stream etc).

----

Well, I tried to split it into a project and compile it, but I get several compiler errors before I can even get to linking.

Firstly, forward declarations normally go into headers to avoid including the header where the full definition is found. If you access members and methods of these classes in the implementation file, a forward declaration is not enough. You need to include all headers in implementation files that the cpp file needs to know about.

Secondly, FILE* fp is a private member in ISBNPrefix, yet you are trying to access it directly from ISBN.

ISBN::empty has a malformed if-condition (caught apparently because the method is const - see where that helps!):

if(ISBN1[0] == '\0' && area[0] == '\0' && publisher[0] == '\0' && title[0] == '\0' && isRegistered = 0)

ISBN::registered appears to contain a stray }

void ISBN::toStr(char* str) const{
  /* *MAKE UNFORMATTED VERSION OF ISBN* */
  strcpy(str,isbn);
}

isbn is undefined (it is not a member, not a global and obviously not a local variable).

And the errors go on and on... (What you posted cannot be the same code that you compiled successfully and cannot link.)

There are also numerous warnings: unused variables and functions that should return something but don't.

[anon]

Or in other words, since you say you are getting linker errors it means that you must be compiling only main.cpp and not any of the other files.

So again, have you created a project with Dev-C++ and added all the cpp files to it? You can compile single-file programs without a project but you need one if you have more files.

[bigmac(rexdale)]

damn, thats alot of problems...how can i use ISBNPrefix's fp because without it this program is useless seeing i need to rewind and read from fp

[bigmac(rexdale)]

Or in other words, since you say you are getting linker errors it means that you must be compiling only main.cpp and not any of the other files.

So again, have you created a project with Dev-C++ and added all the cpp files to it? You can compile single-file programs without a project but you need one if you have more files.

yeah, thats what i've been doing so im looking through and correcting any silly mistakes