Thread: fill array with random number

Hi,
I've been trying to fill an 6x6 array with random number from 1 to 6,
this is my function that takes care of this

Code:

void initArray(int arrayName[][col], int row, int col)
{
	
	for (int i =0; i<row; i++)
	{
		srand(static_cast<unsigned int>(time(NULL)));
		for (int j=0; j<col; j++)
		{	
			arrayName[row][col]= 1+rand()%6;
		}
	}

}

but, when i print out the array, its elements are all the same ...
am I missing anything? (i cannot find anything that is wrong)

thanks for any insight

I had tried that, but the output elements still remains the same.
It should be different for each of the element; however, in this case, they're the same.

am I missing anything?
thanks!

i though the nested for-loop will loop through each element?

I can't get your function to compile, since the second array dimension isn't given. Also you never assign to valid locations (array[row][col] isn't valid -- it's off both edges of the array -- you should be writing to array[i][j] instead).

Ahh! I see. I totally forgot about that..
row=col=6 .. it's a 6x6 array and i tried to generate random number from 1 to 6 with 1 + rand() %6

1+rand()%6 should give out number from 1 to 6 right?
in my case, i got all weird number like -123655390

>> 1+rand()%6 should give out number from 1 to 6 right?
Yes. (Or maybe 1+(rand()%6), I don't remember the precedence.)

Did you fix the arrayName[row][col]= bug?

hi guys
my bad...how come i didn't see that...
it's working..it's my printArray function that prints out out-of-bound element...

thanks again!!!