C++ Clock.

Hello, i have learned a bit more about ctime and loops.

If any of you needed a digital clock code. Here it is if not then it's okay, because i know this script is for beginners.

Here's a way to do it:

Code:

#include <iostream>
#include <windows.h>


int main()
{
    using namespace std;
  

	int minutes = 0; // set the minutes
	int hours = 5; //set the hour

Loop:
   for (int a = 0; a < 61; a++)
   {

	   	  if (a == 60)
		{
			minutes = minutes + 1;
			a = a - 60;
			goto Loop;
		}
		  if (minutes == 60)
		  {
			  hours = hours + 1;
			  minutes = 0;
			  goto Loop;
		  }
		  if (hours == 13)
		  {
			  hours = hours - hours;
			  hours = hours + 1;
		  }


	   	system("cls");
		cout <<"Hours:"<<hours<<"/ Minutes:"<<minutes<<"/ Seconds:"<<a;
	    Sleep(1000);


	}

     
	

	cin.get();

	return 0;

}

This way will just help you learn more about loops and how digital clocks loops works.

Here's a more useful way to do it, to set the time to your computer time.

Code:

#include <ctime>
#include <iostream>
#include <windows.h>


int main()
{
	using std::cin;

	bool loop = true;


	while (loop)
	{


  std::time_t now = std::time ( 0 );
  std::tm *local = std::localtime ( &now );

  local->tm_hour -= 6;
  
  system("cls");
  std::cout << ctime ( &now ) <<'\n';
  Sleep(1000);
  
	}
  cin.get();

  return 0;


}

Thank you, hope you find it useful, actually, for the people who just started c++.

It would be easier (and more readable) to just count in seconds and convert it to a more friendly format.
You can also get rid of the "Loop" label, since you never use it.

I love programming this way...But it's okay if you give me your opinions, because, it helps me learn more. I'll try what you just told me. Thanks Elysia.

Now I see you're using goto. Goto is considered bad practice.
You can use continue to jump to the top of the loop. I'm afraid you'll have to change how your code works, as well. The goto combined with the rest explains why the code is so hard to understand.

Actually, it's my first time using Goto...I don't like it much...So i won't use it again.

And by the way? Elysia, how long have you been programming?

Code:

>		  if (hours == 13)
>		  {
>			  hours = hours - hours;
>			  hours = hours + 1;
>		  }

I take it:

Code:

		  if (hours == 13)
		  {
			  hours = 1;
		  }

is too easy to read.

Code:

>  local->tm_hour -= 6;

This looks like a stray line you forgot to delete.

Thank you swoopy, i could've made it this way:

Code:

if (hours == 13)
		  {
			  hours = 1;
		  }

But, i forgot about it, i'm just having a headache right now, been reading the book for hours now.

Code:

Loop:
   for (int a = 0; a < 61; a++)
   {

	   	  if (a == 60)
		{
			minutes = minutes + 1;
			a = a - 60;
			goto Loop;
		}

You are obfuscating your code - either on purpose or because you don't know any better.

Make the loop end condition be:

Code:

a < 60;

Then add 1 to minutes when the loop finishes (after the loop). At that point, check if minutes == 60, add hours, check hours, etc.

Of course if a == 60, then a = a - 60 is the same as a = 0;

This of course, assuming you don't follow Elysia's excellent advice of counting time in seconds (or milliseconds or minutes, depending on the precision you actually need).

--
Mats