File handling with Array filled with a class

OK - I have a any array of size 30. Each array element is a class that consists of 5 objects.

i have declared it as follow

Code:

---

WeatherReport MonthlyReport[DAYS];

---

Now I want to read input from a file and store it in the array. The objects are all of type int and its things like HighTemp, LowTemp, Rain etc. How do I use an index with classes in arrays?

will it be something like

Code:

---

if_stream>>report.HighTemp[i];

---

and will it be the say for outputing the array after it has been read into memory?
thanks!

If you want to do it the fancy way, you would declare a operator << for the class, that in itself reads the hightemp, lowtemp, rain, wind, etc.

But that may be a bit advanced if you are a beginner, in which case you loop around reading in each element until end of file (unsuccessful reading of value indicates end of file) or full array.

The syntax would be something like:

Code:

---

if_stream >> report[i].hightemp;

---

--
Mats

Ok forget my last post: I figured it out- its just like using a normal array (when you overload the << and >> operators

Code:

---

for(i=0;i<DAYS;i++)
{
in_stream1>>MonthlyReport[i];
}

for(i=0;i<DAYS;i++)
{
cout<<MonthlyReport[i];
}

.
.
.
.

istream& operator>> (istream& ins, WeatherReport& report)
{
ifstream in_stream1;

                in_stream1>>report.DayOfMonth>>report.HighTemp>>report.LowTemp
                >>report.AmountRain>>report.AmountSnow;
}
ostream& operator<< (ostream& outs,const WeatherReport& report)
{

cout<<report.DayOfMonth<<" ";
cout<<report.HighTemp<<" ";
cout<<report.LowTemp<<" ";
cout<<report.AmountRain<<" ";
cout<<report.AmountSnow<<" ";
cout<<endl;
}

---

Ok ,just one problem I need you help with... my in_stream doesn't read the data from the file... any suggestions?

Code:

---

istream& operator>> (istream& ins, WeatherReport& report)
{
ifstream in_stream1;

                in_stream1>>report.DayOfMonth>>report.HighTemp>>report.LowTemp
                >>report.AmountRain>>report.AmountSnow;
}

---

You should use "ins", not a local "in_stream1" variable.

--
Mats

Similarly you should use (and return) the passed stream in operator<<. Now it would compile and even be able to write WhetherReport to file.

Code:

---

ostream& operator<< (ostream& outs,const WeatherReport& report)
{
    outs<<report.DayOfMonth<<" ";
    ...
    outs<<endl;
    return outs;
}

---

Code:

---

istream& operator>> (istream& ins, WeatherReport& report)
{
ifstream in_stream1;

                in_stream1>>report.DayOfMonth>>report.HighTemp>>report.LowTemp
                >>report.AmountRain>>report.AmountSnow;
}

---

Actually, let me ask...
WHY are you using a local variable, the in_stream1? What is the purpose of doing so?

because im a total idiot

Code:

---

friend istream& operator>> (ifstream& ins, WeatherReport& report);
.
.
istream& operator>> (ifstream& ins, WeatherReport& report)
{

 ins.open("InputFile.dat");
               
  for(int i=0;i<DAYS;i++)
  {
  ins>>report[i].DayOfMonth>>report[i].HighTemp>>report[i].LowTemp
  >>report[i].AmountRain>>reporti[i].AmountSnow;
  }

---

It gives me the error "No match for operator[] in report[i]. Any suggestions?

You are passing ONE element of report to the operator >>, not an array. If you want another operator to take an array, then you need to pass an array of the class. But I would say that your loop should be OUTSIDE.

Also, you should not open the file in operator >> - it should be already existing and opened by the code outside of the operator.

--
Mats

Ok sorry but i'm slow today - I need to pass an array to the << operator, not just a single element... how will i do that?

Code:

---

istream& operator>> (ifstream& ins, WeatherReport& report[i])

---

or is it like when I pass an array to a function?

The easiest way is to just make your array a std::vector and pass that by reference.
Otherwise you can pass a pointer.

Quote:

---

Originally Posted by MarlonDean

Ok sorry but i'm slow today - I need to pass an array to the << operator, not just a single element... how will i do that?

Code:

---

istream& operator>> (ifstream& ins, WeatherReport& report[i])

---

or is it like when I pass an array to a function?

---

It is like when you pass an array to a function, but in this case, my suggestion is to make a loop OUTSIDE the operator >>, and use your existing "read on report" operator >> to read the required number of elements into the array.

--
Mats

How would you write a vector of int's to a file? Writing WhetherReports to a file should not be different at all.

When overloading operators the general guideline is to make the behaviour similar to built-in (or already existing) types.

Code:

---

int i;
ofstream fin;
fin >> i;

---

Does this work? No, because no file is opened. Therefore operator>> overloads shouldn't open or close any files either.

If the behaviour you want from these operators is too different, you should consider a named function instead - operator overloading is just syntactic sugar, not something you absolutely must do. It is sweet only as long as the behaviour of the operator is very similar to other types: the user of your class already knows how to use operator>>, so they should be able to use it right away without having to study references on how the function is exactly supposed to be used.

Just want to check if you have a solution to the problem as I am experiencing the same problem with the No match for operator[] compilation error.

Would appreciate any help.

For what code? Are you passing a non-array by reference, as the OP?

>> Would appreciate any help.

I think it would be best to start a separate thread and post your code and the exact error message. These types of errors can have many different causes.

Persoanlly, I woudl just treat the class as if it were a struct. The member functions are only contextual, they dont actually occupy space in the object. You may want to use #pragma pack(1) to guarantee the smallest footprint

I declare it in my class and when I wnat to use the function as below I get the error message No match for operator[]. If I remove the line dayReport[i].dayOfMonth = dayP then it works but it is not read into the array.

Code:

---

istream& operator >> (istream& fin, weatherReport dayReport[])
{
    Do something
    dayReport[i].dayOfMonth = dayP;
}

---

I think you should be reading into a weatherReport & instead of into the array. That's just how it's done in C++. Move the code that loops through the array into a separate function and read into each weatherReport one at a time.