Arrary & ForLoop

**anon** · 05-15-2008

Array indices go from 0 to array_size, but not including it. Your for loop tries to access your_array[your_array_size] because the loop condition is wrong. Can you see how to fix it?

(And please replace every instance of 15 in your code with LIMIT, because that's what its for.)

**abh!shek** · 05-15-2008

yeah, it should be counter<=14 in the for loop

**slimdime** · 05-15-2008

Oh, a comedian.

Ok, let me see if I can do that. (be right back)

**anon** · 05-15-2008

Originally Posted by abh!shek

yeah, it should be counter<=14 in the for loop

Not really. There is a perfectly meaningful constant LIMIT. 14, on the other hand is quite obscure magic value. Therefore the condition should be counter < LIMIT.

The whole point of insisting on using LIMIT everywhere instead of the magic value 15 (or 14) is, that if you want to change the size of the array, the only thing to change would be the value of LIMIT.

On the other hand, if you use magic numbers throughout the code you'd have to locate them all one by one. This would be particularly hard, if 15 could stand for more than one logical constant in the code (e.g there are two unrelated arrays, both initially sized 15, but now you'd want to change the size of just one). It is also harder, if there are other values, somehow related to 15 (like 14, which is 15-1).

**abh!shek** · 05-15-2008

yep, thx.

**slimdime** · 05-15-2008

IDK

What about:

Code:

for ( int x = 0; x < 15; x

**abh!shek** · 05-15-2008

aaaaabbbbbbbbbbaaaaaaarrrrrrrrrrrrrrrrrrrooo

Code:

for(counter=14;counter>=0;counter--)
{
    cout<<array[counter]<<endl;

}

**slimdime** · 05-15-2008

Thanks, but it's still not working:

Code:

#include "stdafx.h"
#include <iostream>

using namespace std;



int main()
{
 int array[15]
for (counter=0;counter=<15;counter++)
{
cout<<"please enter a number"<<endl;
cin>>array[counter];
}	
  
for(counter=15;counter>=0;counter--)
{
    cout<<array[counter]<<endl;

}

  return 0;
}

**abh!shek** · 05-15-2008

Code:

#include "stdafx.h"
#include <iostream>

using namespace std;



int main()
{
 int array[15];
for (counter=0;counter<15;counter++)
{
cout<<"please enter a number"<<endl;
cin>>array[counter];
}	
  
for(counter=14;counter>=0;counter--)
{
    cout<<array[counter]<<endl;

}

  return 0;
}

**slimdime** · 05-15-2008

Getting this error:

error C2065: 'counter' : undeclared identifier

**abh!shek** · 05-15-2008

Originally Posted by slimdime

Getting this error:

error C2065: 'counter' : undeclared identifier

You figure out yourself why you are getting this error. I'm busy making a cool virus that blows up computers, so I can't look into your program right now.

**slimdime** · 05-15-2008

OK. (running away very fast) Thanks.

**slimdime** · 05-15-2008

GOT IT!!

Code:

#include <stdafx.h>

#include <iostream>  
  
using namespace std;  
  
const int LIMIT = 15;  
  
int main()  
{  
    int array[LIMIT];  
  
    for (int i = 0; i <= LIMIT; i++)   
    {  
        
        cout<<"please enter array member #" << i << ": ";  
         
        cin>>array[i];  
    }  
   
    for (int i = LIMIT; i >= 0; i--)  
        
        cout << "Array member #" << i << ": " << array[i] << endl;  
   
    system ("pause");  
    return 0;  
}