Using fstream help.

I need to read in up to six text files from command line agruments. This is the code I have but it exits at the if(!fin) exit(1); line and I don't know why.

Code:

#include <fstream>
#include <iostream>
#include <string>
#include <vector>

using namespace std;

int main(int argc, char* argv[])
{
   vector<vector<string> >   words;
   string word;
   int wordCount =0; 
   
   cout<<"before loop";
   for(int i=1; i < argc; i++)
   {
      ifstream fin(argv[i]);
      if(!fin) exit(1);
  
      cout<<"after loop";
      wordCount =0;
     
     
      while(!fin.eof())
      {
         fin>>word;
         cout<<word<< "-";
         words[i][wordCount] = word;
         wordCount++;
      }

      
   }

for(int i =0; i< words.size(); i++)
   for(int x=0; x< words[i].size(); x++)
      cout<< words[i][x] << " ";


}

Probably because the first file failed to open.

Are you sure the path is correct? Use an absolute path just to make sure. Since it is an input file the file must exist at that location.

BTW, while (!fin.eof()) often leads to incorrect data by processing the last word twice. The common way to do this is to move the read into the while:

Code:

while(fin >> word)

I'm doing over a server but I checked and the text file is in the same directory as the program. I saved the file as test.txt and to run it I do ./execProg test

But "test" is different that "text.txt". That's probably your problem. Your fstream doesn't do OS specific stuff like automatically add file extensions and stuff. You have to use the exact filename.

If it still doesn't work, you should try to use an absolute path because the working directory is not always the same as the current directory. It sounds like it will be fine in your case, but if it isn't you should use the absolute path to make sure that's not the problem.

the error i get is: segmentation fault (core dumped)

That means it's opening the file. The problem is probably because you are accessing elements in words that don't exist. You created that vector of vectors as empty. When you use operator[] on a vector (just like an array) there has to be something at that location. You probably want to either push_back a new vector for every file that you open, or construct words with argc-1 inner vectors to start with.

Once you fix that, you'll have the same issue with the inner vectors, although simply using push_back instead of wordcount will likely fix that.

Note that if you use cerr instead of cout, or if you add endl or flush to your cout statements, the output should show how far you get before the segmentation fault. If you aren't seeing any output before that error, it's likely just because the two cout statements hadn't been flushed to the console yet.

Right now I have vector<vector<string> > words; but how do I define it with the first dimesion using argc-1 and not define the second dimesion so I can use .push_back() Thanks for your help.

Code:

vector<vector<string> > words(5);

That code creates a vector of 5 empty vectors. Adjust to suit your needs.

Got it. Thanks for your help