Program stops executing

Code:

---

// new code down below

---

Hope the above isnt too much code to put here, but after I try to exit the loop early and return the structure in the getData function, the program just stalls. Can somebody please point me in the right direction.

p.s is the way im deleting p the right way to delete the allocated array?

This doesn't compile as is (static keyword misused).

I would also suggest turning compiler warnings on.
The most alarming part is this:

Code:

---

Store        *d, *e;
*d = getData(size, loopie);
menu(d, loopie);
*e = reData(d,loopie);
menu(e,loopie);

---

What you are doing here is declaring two uninitialized pointers, then you dereference d to assign a value returned by getData and pass the uninitialized pointer to another function, and repeat the same error.
Instead getData should return a pointer to the block of memory it allocated. reData probably doesn't need to return the pointer because it is just modifying the array contents?
All in all this part should look something like this:

Code:

---

Store        *d;
d = getData(size, loopie);
menu(d, loopie);
reData(d, loopie);
menu(d, loopie);

---

Other than this error the indentation leaves much to desire and the architecture is weird. When I look at main, I see this:

Code:

---

int main()
{
greeting();
return 0;

}

---

So, the only thing this program does is greet the user?

Another major weirdness is this:

Code:

---

void display(Store p[], int &loopie)
{
//... snip ...
delete [] p;
}

---

A display function that destroys the data it displays?!
If possible, the function that allocates the memory should also delete it. Assuming, greeting returns the desired size for the array, your main program might look like this:

Code:

---

int main()
{
    //ask user, how many Stores they want
    int max_size = Greetings();

    //main allocates memory, so we needn't guess which function should deallocate
    Store* stores = new Store[max_size];

    //fill it up with data
    int entry_count = GetData(stores, max_size);

    //run menu, which allows user to modify and display the entries
    Menu(stores, entry_count);

    //main deallocates resources and exits
    delete [] stores;
    return 0;
}

---

You'll need to change your function prototypes for that.

I find this odd?

Code:

---

void display(Store p[], int &loopie)
{
//... snip ...
delete [] p;
}

---

It is passed an array not a pointer. How is that working?

Quote:

---

Originally Posted by Raigne

I find this odd?

Code:

---

void display(Store p[], int &loopie)
{
//... snip ...
delete [] p;
}

---

It is passed an array not a pointer. How is that working?

---

When arrays are passed to functions, they are ALWAYS turned into pointers, whether that is explicit (Store *p) or implicit (Store p[]).

--
Mats

http://cpwiki.sourceforge.net/Common...llocating_them

Quote:

---

What you are doing here is declaring two uninitialized pointers, then you dereference d to assign a value returned by getData and pass the uninitialized pointer to another function, and repeat the same error.
Instead getData should return a pointer to the block of memory it allocated. reData probably doesn't need to return the pointer because it is just modifying the array contents?
All in all this part should look something like this:

---

Code:

---

Store        *d;
d = getData(size, loopie);

---

d will have the address of the returned value(the array of structures) ?

Quote:

---

Other than this error the indentation leaves much to desire and the architecture is weird. When I look at main, I see this:

---

Code:

---

int main()
{
greeting();
return 0;

}

---

I cant have it so greeting calls all the other functions? Or is it considered good to have all the function calls so someone taking a first glance will know whats going on right away?

Quote:

---

So, the only thing this program does is greet the user?

Another major weirdness is this:

---

Code:

---

void display(Store p[], int &loopie)
{
//... snip ...
delete [] p;
}

---

I was gonna have it delete the memory after all the info was displayed. Are you only able to delete memory in int main?

Code:

---

int main()
{
    //ask user, how many Stores they want
    int max_size = Greetings();

    //main allocates memory, so we needn't guess which function should deallocate
    Store* stores = new Store[max_size];

    //fill it up with data
    int entry_count = GetData(stores, max_size);

    //run menu, which allows user to modify and display the entries
    Menu(stores, entry_count);

    //main deallocates resources and exits
    delete [] stores;
    return 0;
}

---

Cool, man. I'll try that out. Thanks for the help.

Quote:

---

Originally Posted by bargomer

Code:

---

Store        *d;
d = getData(size, loopie);

---

d will have the address of the returned value(the array of structures) ?

---

In this case yes. getData of course should return the pointer not a copy of the contents of the first thing that the user entered. (In my suggested main such code wouldn't be needed, though.)

Quote:

---

I cant have it so greeting calls all the other functions? Or is it considered good to have all the function calls so someone taking a first glance will know whats going on right away?

---

Of course you can do that. But the question is, why is this function called greetings, if it not only greets the user but runs the whole program? It makes code much easier to follow if a function achieves one clear task that can be inferred from their name.

Quote:

---

I was gonna have it delete the memory after all the info was displayed. Are you only able to delete memory in int main?

---

You can delete memory anywhere you want. Except doing so in completely random and unexpected places makes memory management very hard.
When you go to an ATM to view your account balance, do you expect this operation to close your bank account?
In addition, you had this code:

Code:

---

Store        *d, *e;
*d = getData(size, loopie);
menu(d, loopie);
*e = reData(d,loopie);
menu(e,loopie);

---

If the user selected to display the contents the first time menu is called, the memory won't exist anymore so you could re-enter and call menu again.

Quote:

---

Code:

---

int main()
{
    //ask user, how many Stores they want
    int max_size = Greetings();

    //...snip...
}

---

Cool, man. I'll try that out. Thanks for the help.

---

You are welcome. You'll need to change all your functions to make that code work. For example this main function expects that none of the functions called in between (or functions called from any of those) won't deallocate the array etc :)

I'm now getting an Unresolved external error.

Error: Unresolved external 'getData(Store, int)' referenced from C:\USERS\BARAZIN\DOCUMENTS\PROJECT9.OBJ
Error: Unresolved external 'menu(Store, int)' referenced from C:\USERS\BARAZIN\DOCUMENTS\PROJECT9.OBJ

Code:

---

#include <iostream>

using namespace std;

struct Store
{
        char name[30];
        int ID;
        double balance;
};

int greeting(), getData(Store , int);
void menu(Store, int),display(Store, int), reData(Store &, int);

---

Those errors usually occur when you dont put the right functions right? Can anybody explain why this is happening?

Common error: you may have two or more files and forgot to compile and link all files.
Or you misspelled the prototype function names and used those instead of the correct names.

Quote:

---

Originally Posted by Elysia

Common error: you may have two or more files and forgot to compile and link all files.
Or you misspelled the prototype function names and used those instead of the correct names.

---

Weird. It looks like my prototypes and headers are the same. I have another program that uses the same structure names, but they aren't related in anyway.


*edit*

Not sure how its actually working, but the code pretty much looks like it does in my oringal post. I don't think im using more than one file.

Your reply doesn't make much sense.
Say you have two or more files, such as a.cpp, b.cpp, c.cpp. Then you need to compile and link them all into a binary. Easiest if you use an IDE that does it for you (the way it should be done).
Or you could have made a slight error such as:

Code:

---

void fifo();
void fiifo()
{
}

int main()
{
    fifo();
}

---

Note how the prototype and definition doesn't match. This will also give a linking error.

Your prototypes don't match the code:

Code:

---

int greeting(), getData(Store , int);
void menu(Store, int),display(Store, int), reData(Store &, int);
void menu(Store temp[], int &loopToFun)
Store reData(Store stru[], int &looper)

---

[CODE[/CODE]

That's how the new code looks like. Was taking anon's advice on changing the structure of my program. Everything looks like its matching up to me :'(

Quote:

---

Originally Posted by bargomer

Everything looks like its matching up to me :'(

---

Then you should look closer (or maybe at all): your prototype for menu is

Code:

---

void Menu(Store, int);

---

while the function you define is

Code:

---

void menu(Store bank[], int loopToFun)

---

Notice how Store and Store[] are not in fact the same thing.
Also:

Code:

---

void reData(Store &, int);

---

has no parameters at all in common with your function

Code:

---

void reData(Store stru[], int &looper)

---

as Store & does not match Store[] and int does not match int&.

Quote:

---

Originally Posted by tabstop

Then you should look closer (or maybe at all): your prototype for menu is

as Store & does not match Store[] and int does not match int&.

---

AHHHHH!!! Didn't even notice that I hadn't changed some of them again. Figured it was something else causing the problems. Thanks!



*edit*

Thanks everybody finally got it to run the I wanted it to.

Make sure your prototypes match the definitions. And don't clear out the variable names. Just do copy n' paste.
And it's a bad thing(TM) to edit out your post with your code once you got your answer. How can other people learn from the thread then?

whoops, sorry didnt think about that. Didnt want ppl have to scroll down the page of so much code.