Thread: Don't Understand

Hi guys I'm trying to get this program to sort my array in the second option and i think i have the bubble sort written correctly but it doesn't do anything. Any ideas


//This program takes 20 inputs from the user, and gives the choice to show sorted data,
//sort the data into descending order, display the sorted data, and display the address of the first element.

Code:

#include <iostream>
using namespace std;
#include <iomanip> 
#include <algorithm>

int main()
{
	int i,num[20],n,j,choice,tmp;


	cout<< "Please enter 20 integers";
	for (i=0; i<20; i++)
	
	{
		cout<<"\nEnter next value:";
		cin>>num[i];
		
	}
	
		

		cout<<"\n1.Display original data.\n";
		cout<<"2.Sort the data into descending order\n";
		cout<<"3.Display the sorted data (Only if you've already sorted)\n";
		cout<<"4.Get the address of the first element of array.\n\n";
		cin>>choice;
	
	if (choice==1){
		
		for (i=0; i<20; i++){
			cout<<"\n"<<num[i]<<endl;		
		}
	if (choice==2){
		for (i=0; i<n-1; i++) {
			for (j=0; j<n-1-i; j++)
    if (num[j+1] < num[j]) {  /* compare the two neighbors */
		tmp = num[j];         /* swap a[j] and a[j+1]      */
		num[j] = num[j+1];
		num[j+1] = tmp;

	cout<<"Here are your numbers:"<<tmp<<endl;
} 
}
	}}}

Kindly edit your code is just use code bbcode tags instead of php bbcode tags (or just php bbcode tags, if you really want, but the syntax highlighting may not be correct). Also, indent your code more consistently so that it is easier for everyone to read.

i think i have the bubble sort written correctly but it doesn't do anything

You need another loop to print the array of numbers.

I'm not sure I understand. Do you mean I need another for loop before my cout statement?

Oh, I very badly misread your code. Really, you need to indent your code, e.g.,

Code:

#include <iostream>
#include <iomanip>
#include <algorithm>

using namespace std;

int main()
{
    int i,num[20],n,j,choice,tmp;

    cout<< "Please enter 20 integers";
    for (i=0; i<20; i++)
    {
        cout<<"\nEnter next value:";
        cin>>num[i];

    }

    cout<<"\n1.Display original data.\n";
    cout<<"2.Sort the data into descending order\n";
    cout<<"3.Display the sorted data (Only if you've already sorted)\n";
    cout<<"4.Get the address of the first element of array.\n\n";
    cin>>choice;

    if (choice==1)
    {

        for (i=0; i<20; i++)
        {
            cout<<"\n"<<num[i]<<endl;
        }

        if (choice==2)
        {
            for (i=0; i<n-1; i++)
            {
                for (j=0; j<n-1-i; j++)
                    if (num[j+1] < num[j])    /* compare the two neighbors */
                    {
                        tmp = num[j];         /* swap a[j] and a[j+1]      */
                        num[j] = num[j+1];
                        num[j+1] = tmp;

                        cout<<"Here are your numbers:"<<tmp<<endl;
                    }
            }
        }
    }
}

The main change I did was to move down your using directive, but that probably has no effect on your code. More importantly, I ran it through a code formatter. Can you see your branches of logic, as implemented in your code, more clearly now, and thus see what is wrong?

but to me it looks like my if(choice==2) is actually within if(choice==1) and thus the compiler doesn't know what i'm wanting it do....?

Well, the compiler never knows what you want to do, only what you told it to do. But yes, you have the right idea: that block of code that is supposed to be run when choice is 2 is unreachable since it can only be run if choice is both 1 and 2 simultaneously, which is impossible.

I recompiled and ran it and it does the same thing and tells me that my 'n' is uninitialized. So do i still have the same error as before?

Look carefully at where you use n, and see where you give it a value (or rather, fail to do so).

n is the number of elements to be sorted. Since you require the user to enter all 20 numbers, you should set n to 20.