returning this pointer

**chottachatri** · 03-30-2008

Hello,
i am confused whether in the following code i should return reference or not!

Code:

#include <iostream.h>
class set
{
  int data;
  public:
	void getdata(int d)
	{
		data=d;
	}
	void putdata()
	{
		cout<<data;
	}
	set max(set B);
};
set set:: max (set B)
{
	if(data>B.data)
		return *this;
	else
		return B;
}


int main(void)
{
 set a,b;
 a.getdata(30);
 b.getdata(20);
 b=a.max(b);
 b.putdata();
 return 0;
}

Is the above code correct??if Yes then B is call by value and when we return B the address of B will be changed even though we return the same object B .Right or not?

Please tell me whether i should return reference or the above code is correct?

**Dino** · 03-30-2008

Seems to work fine as it is.

Todd

**laserlight** · 03-30-2008

I think it is functionally correct (but with a pre-standard header included), though it is not const correct and could be improved with pass by reference and better naming, e.g.,

Code:

#include <iostream>

class set
{
public:
    void setdata(int d)
    {
        data = d;
    }
    
    int getdata() const
    {
        return data;
    }

    const set& max(const set& B) const;
private:
    int data;
};

const set& set::max(const set& B) const
{
    return (B.data < data) ? *this : B;
}

int main()
{
    set a, b;
    a.setdata(30);
    b.setdata(20);
    b = a.max(b);
    std::cout << b.getdata();
    return 0;
}

**chottachatri** · 03-30-2008

Ok laser
But if i dont use reference & then is it correct way of doing it?I mean this is much more efficient but still is that way also correct?

**laserlight** · 03-30-2008

But if i dont use reference & then is it correct way of doing it?I mean this is much more efficient but still is that way also correct?

Yes.

Thread: returning this pointer

Thread Tools

Search Thread

Display

returning this pointer

Similar Threads

Dynamic array of structures containing yet another dynamic array of structures

towers of hanoi problem

Quick question about SIGSEGV

Another Linked List plee

returning pointer to string between exe and dll