Thread: Whats wrong with this simple code?

Allright, i'm a total beginner, and i'm just testing stuff.

Well i was trying to make this password check, but it won't run...

Something about thisisapassword being an undecleared identifier.

Could someone please tell me how it should look like?

please.

Code:

#include <iostream>

using namespace std;

int main()
{
  char string[256];                               // A nice long string

  cout<<"======== WELCOME TO MY TOP SECRET PROGRAM =======\n";
  cout<<"Password: ";
  cin.getline ( string, 256, '\n' );              // Input goes into string
  if(string==thisisapassword) {
	  cout<<"Correct password!";
  }
  else {cout<<"Wrong password";
  cin.get();}
}

Another problem is that you are comparing C style strings with ==. That doesn't work because it ends up comparing pointers that can be different even if the strings are the same. In C, you use strcmp to compare strings.

However, this is C++, and there's no reason to use C style strings. Add #include <string> and change your string variable to have the type string (you'll want to give it a different name so that the names don't conflict):

Code:

string userPassword;

Once you do that, you'll want to change the version of getline you're using because the one for C++ strings is different:

Code:

getline ( cin, userPassword );

Then you can use == like your code does now and it will work as you expect.

Thanks for the reply, ill try to use the c++ string instead, I had only learnt the C ones ;D