Thread: Reading in data from Text file

Originally Posted by matsp

Yes, and I understand that you want this to be a function - but I don't understand what is IN your function, and what your call to the function looks like, and what exactly doesn't work when you use the function. That is the code I want posted - because that's the code you want to have working.

But I think it will have to wait for later, as I'm off to bed now.

--
Mats

ok cheers for ur help up till now

these are the varibles that are mainly involved

char pos[2][16], = the use inputs a 2 place names via the loop
char place[11][11], = stores all the place names which is gatherd via the read function
int point[2] = holds the 2 points which corresponds with the place name

Originally Posted by matsp

Yes, but I need to see BOTH the function code and the code that calls the function - because if it's not working, then you are doing something wrong either in the calling of the function, or inside the function.

It would also help if you describe what actually goes wrong (e.g. it doesn't find the right city).

--
Mats

ok ill start it off simple

this is my function

Code:

void places()
{
   char pos[2][16];
   char place[11][11];
   int point[2];
   int i, x, wrong, flag;
   for(i=0;i<2;i++) // loops round  twice allowing the input of 2 points
            {
                 if(wrong!=1)
                 {           
                    if(i==0){printf("\n Please enter your Start point: ");} // input first point 
                    if(i==1){printf("\n Please enter your Finishing point: ");} // input first point  
                    
                 }  
                    wrong=0;  
                    scanf("&#37;16s", pos[i]);
                    size_t x;  
                          flag = 0;
                          for(x = 0; x < sizeof(place) / sizeof(*place); x ++) 
                            {
                               if(strcmp(place[x+1], pos[i])==0)
                               {
                               point[i] = x;
                               flag=1;
                               }
                            }
                            if(flag==0)
                            {
                               printf("\n Invalid place name please re enter: ");
                               i--;
                               wrong=1;       
                            }
            }

This is how i call it

Code:

places();

and this is my output:

http://i57.photobucket.com/albums/g2...Untitled-2.jpg

it deosnt recognize any valid places which are input


thats what i have for a starter

Originally Posted by dwks

Code:

                          for(x = 0; x < sizeof(place) / sizeof(*place); x ++) 
                            {
                               if(strcmp(place[x+1], pos[i])==0)
                               {
                               point[i] = x;
                               flag=1;
                               }
                            }

place[x + 1] will cause a buffer overrun during the last iteration of that loop.

But it doesn't matter, because you never read anything into your place[][] array. You need to put data into that array.

i have 11 items in my array i dont understand

i just need that for loop to work in the method i dunno what i need to add to it to get it working

aghhhhgot yaaa instead od

for(x = 0; x < sizeof(place) / sizeof(*place); x ++)


shall i just change it to summin like x =0;x<10;x++

will that achive the same thing? without an overrun

atm i aint really worried bout the buffer ect atm im trying to get this function working

Originally Posted by matsp

Yes, but I need to see BOTH the function code and the code that calls the function - because if it's not working, then you are doing something wrong either in the calling of the function, or inside the function.

It would also help if you describe what actually goes wrong (e.g. it doesn't find the right city).

--
Mats

ok ill start it off simple

this is my function

Code:

void places()
{
   char pos[2][16];
   char place[11][11];
   int point[2];
   int i, x, wrong, flag;
   for(i=0;i<2;i++) // loops round  twice allowing the input of 2 points
            {
                 if(wrong!=1)
                 {           
                    if(i==0){printf("\n Please enter your Start point: ");} // input first point 
                    if(i==1){printf("\n Please enter your Finishing point: ");} // input first point  
                    
                 }  
                    wrong=0;  
                    scanf("&#37;16s", pos[i]);
                    size_t x;  
                          flag = 0;
                          for(x = 0; x < sizeof(place) / sizeof(*place); x ++) 
                            {
                               if(strcmp(place[x+1], pos[i])==0)
                               {
                               point[i] = x;
                               flag=1;
                               }
                            }
                            if(flag==0)
                            {
                               printf("\n Invalid place name please re enter: ");
                               i--;
                               wrong=1;       
                            }
            }

This is how i call it

Code:

places();

and this is my output:

http://i57.photobucket.com/albums/g2...Untitled-2.jpg

it deosnt recognize any valid places which are input


thats what i have for a starter

ive read it and well ill deal with that at the end ive been playing with my prog dont see any problems

Originally Posted by Elysia

No it doesn't. Read my reply again.

my main concern is figuring out how to get that piece of code into a fucntion so it runs all good and stuff when i call it to work all good so i dont have to have the same code in my program twice just call it twice