Thread: Reading in data from Text file

i have a loop to read in from the text file

Code:

char place[11][11]
     {
	       for(i=0;i<11;i++)
	       {
	     	fscanf(in_file, "&#37;s ", &place[i]);
	        }

i need this constructor to get the data from the place array or re read from text file i cant have it set how it is below

Code:

const char *cities[] = {"London", "Glasgow", "Birmingham", "Manchester", "Luton", "Derby", "Poole", "Stafford", "Stoke", "Cardiff"};

Mats, Patience not deniable. Statement made pertaining to over all of posts. Talented - yes, a little abrasive on some responses - yes. Please understand this is not an attack. It's a matter of seeking improvement on information transfer. It was something that needed to be said. Others on this forum would have loved to present what was said, but they do not post in fear of possible reduction in information. Please note that it goes without saying that there are allot of members on this board that do appreciate the contributions that you, Elysia, and all others who know who they are provide. All members on this forum should receive positive direction at all times.

Originally Posted by matsp

Code:

fscanf(in_file, "%s ", &place[i]);

remove the &.

If you add a

Code:

printf("'%s'\n", place[i]);

do you get the right city names?

--
Mats

yea when i call to print out it works fyne i use this to print out the palces array

Code:

   for (row=0; row<11;row++) 
        {
            printf("%-11s",place[row]);
        }

sooo all the correct place names are sotred in the array i just need to get them into the constructor somehow

Originally Posted by matsp

So, what exactly are you doing to try to achieve that - if your places array is correctly read then you can replace your cities constant with the places array.

Of course, the places array only needs to be 10 elements long, not 11 - but a spare slot at the end will not hurt anything in a modern machine - it's only another 11 bytes after all. But to be pedantic, the array declaration should be:

Code:

char place[10][11]

--
Mats

hmmm yes but i use the constructor for determing input

i use it for

Code:

          for(x = 0; x < sizeof(cities) / sizeof(*cities); x ++) 
                            {
                               if(strcmp(cities[x], pos[i])==0)
                               {
                               point[i] = x;
                               flag=1;
                               }
                            }
                            if(flag==0)
                            {
                               printf("\n Invalid place name please re enter: ");
                               i--;
                               wrong=1;       
                            }

i need the place names in the constructor but i can set them statically so i have to get them from text file or places array

Originally Posted by matsp

So, now I'm quite confused about what you are asking for.

What I was trying to say is that you should be able to do:

Code:

          for(x = 0; x < sizeof(place) / sizeof(place[0]); x ++) 
                            {
                               if(strcmp(place[x], pos[i])==0)
                               {
                               point[i] = x;
                               flag=1;
                               }
                            }
          if(flag==0)
                            {
                               printf("\n Invalid place name please re enter: ");
                               i--;
                               wrong=1;       
                            }

I also updated your indentation to match the code-flow.

Of course, with the above change, the constant cities array is no longer needed [at least not here, and you should be able to replace it similarly in all other places]

--
Mats

thankyou i shall see if this fixes my problem

Originally Posted by matsp

It's probably easiest to just skip the first item on the cities row, by adding a dummy fscanf() before the for-loop that reads the city names.

--
Mats

what do you mean by that ?

i think ive cracked it still testing this is what ive got

Code:

     for(x = 0; x < sizeof(place) / sizeof(*place); x ++) 
                            {
                               if(strcmp(place[x+1], pos[i])==0)
                               {
                               point[i] = x;
                               flag=1;
                               }
                            }
                            if(flag==0)
                            {
                               printf("\n Invalid place name please re enter: ");
                               i--;
                               wrong=1;       
                            }

x+1 pushes the array up 1 so it forgets bout -

sorry for poor formatting

what you think outputs seem good ect