Novice program, plz help

[Johnta]

#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <ctype.h>
#include <conio.h>


#define MAX		100
#define MIN		1

int grades, number, count, ch;

int main(void)
{
 printf("\nDo you want to add some grades? (Y/N) ");
 ch = toupper((int)getch());

 if (ch == 'N') {
 printf("\nAlright have a nice day\n");
 system("pause");
 return 0; }

 else

 do {
 number = MIN;
 grades = 0;
 count=0;

} while (number++ != (MAX));
printf("Enter grade");
scanf("%d",++ grades);
++ count;
printf("%d / %d = ",grades,count);
	printf("\nDo you want to enter another Grade? (Y/N) ");
        ch = toupper((int)getch());
		printf("\n");
  } while (ch != 'N');
 }
 }

Keep getting a parse error before the last while.

[tabstop]

You have three open-curly-braces and five close-curly-braces. The close-curly-brace right before the last while corresponds to the open-curly-brace of int main, so all that code is hanging outside of everything.

If you mean that last while to be part of a do-while loop, well, then you need the do part somewhere.

[vart]

use proper indentation!!!

alt_F8 in VS will help

int main(void)
{
	printf("\nDo you want to add some grades? (Y/N) ");
	ch = toupper((int)getch());

	if (ch == 'N') 
	{
		printf("\nAlright have a nice day\n");
		system("pause");
		return 0; 
	}
	else
		do 
		{
			number = MIN;
			grades = 0;
			count=0;
		} while (number++ != (MAX));
	printf("Enter grade");
	scanf("%d",++ grades);
	++ count;
	printf("%d / %d = ",grades,count);
	printf("\nDo you want to enter another Grade? (Y/N) ");
	ch = toupper((int)getch());
	printf("\n");
}

while (ch != 'N');
}
}

you will see that your while is place outside any function

[cas]

In addition, while it's correct to cast the argument to toupper(), you need to cast it to unsigned char, not int. Unless getch() returns unsigned char (which I doubt, but I can't be certain). So toupper() should be called something like this:

int ch = getch(); /* I assume getch() acts like getchar() */
if(ch == EOF) ... /* oops */
ch = toupper( (unsigned char)ch );

Why that particular cast? Because C says so (and it says so in order to allow an implementation to provide ctype macros that do table lookups).

You'll also want to make sure you pass the proper type to scanf(); ++grades has type int which is not what %d expects (it expects a pointer to int).

[Elysia]

Shouldn't be using getch in the first place... Supposed to be using getchar().

[xuftugulus]

Actually, when you use getchar() how do you get input as 1 character at a time from keyboard, if you don't know your tidbits? I think the main reason people use getch() is because it does that easily for them. And sometimes things that work are the things you tend to use, even if someone says for obscure reasons to you, not to.

[Elysia]

Indeed, but getch() is just more unportable which is why getchar() is suggested.

[xuftugulus]

Do you think that most people posting here care about portability? You are just repeating to them things they barely understand yet. And i must say you are getting tiring sometimes.

[Elysia]

Oh, so we should ignore portability?
That's what this forum is about - safe and portable code, among other things.
There is a reason people suggest avoiding getch and cornio.h. I'm not the only one.

[manav]

well first make sure they get good books and good teachers!
they are just new to all this and will obviously do as the book or teachers explains!
and if some one is so confused about, say, while loops, don't feel bad if he cant value portability!

[Elysia]

There is a fine line, of course. But switching getch() for getchar() isn't particularly hard so I think we can afford to suggest that.

[vart]

Do you think that most people posting here care about portability? You are just repeating to them things they barely understand yet. And i must say you are getting tiring sometimes.

It is all about learning right habbits
When people learn in the University they use the tools required by the teacher like TC 3.0

When they came afterwards to work in some real envirounment they will be requested to use the compiler available in this place like VS6.0, VS2005, gcc, etc

If they get a right habbits of writing portable code - they will have no need to unstudy what was learned and study the new ways of writing the same basic things

[robwhit]

It's also making it so that the people here can compile the code.