Thread: iam a noob and i need help please

Dear gurus
iam crying for help with my program. i can not get anything to appear on the screen. can someone explain to me what i did wrong.
Please someone help me out iam a nob, so i only know basic coding.
here is my program.

This program should have 3 functions
A) explain() explain the program to the user
B)get_radius() input a radius and return a value to main()
C)calc_display() calculate the surface and prints the surface area and volume using the volumes #define statement and display this values to 3 decimal places

Formula
volume of sphere = (4/3)*3.14*radius^3
surface of area of spehere = 4*3.14*raidus^2


/*
Title: Sphere
Name: TONY
Date: feb 21 2008
Description: calculate the surface area and volume of a sphere.
The user will input a radius and the program will
do both calculations
*/

#include<stdio.h>
#include<stdlib.h>
#include<conio.h>
#include<math.h>

#define radius (diameter/2)
#define (radius) pow((4/3)* 3.14*pow(radius,3) // formula volume of a sphere
#define 4*3.14*pow(radius,2) // formula surface area of a sphere

// Function Prototype
void explain (void);
float get_radius (float a);
void calc_display (float area, float volume);

// Function Call
main()
{
float answer, t, e;
system("cls");
explain();
e=get_radius(t);
calc_display(e,t);
system("cls");
getch();
return 0;
}


//Function definition
void explain (void)
{ puts("");
puts("");
}

float get_radius (float a)
{ printf("please give me the radius");
scanf("&#37;f",&a);
return(a);
}

void calc_display (float area, float volume)
{
printf("The area is %.3f and the volume %.3f", area, volume);
}

edit your message - add code tags around the code, make sure you have proper indentation (think about people you ask to help you)

Some things I can spot right away are:
* main should return int.
* It's better to use getchar() instead of getch()
And maybe you should also explain a little better what "no output" means. Do you get the typical dos window? And is it just blank?

Instead of using #define statements, and since you seem to understand how to write a function, why not write a function like get_radius, that will be called get_volume and pass in radius as a parameter, and return the formula calculated over that parameter?

Your entire program looks like you ain't got a clue what you are writing. I don't understand how it even compiles?

Code:

#define 4*3.14*pow(radius,2) // formula surface area of a sphere

Think what you are #defining here if you know that the syntax of #define is:
#define IDENTIFIER TEXT...

instead of pow(radius,2) use
radius*radius

you do not know if the pow function if optimized to process the square in a special way

main should be

Code:

int main(void)

get_radius does not need a parameter

Code:

float get_radius (void)
{
	float radius;
	printf("please give me the radius: ");
	fflush(stdout); /* in case the stdout stream is buffered */
	if(scanf("%f",&radius) == 1)
		return radius;

	/* incorrect input */
	return -1;
}

and so on

macros should be made into functions, compiler will inline them when needed

How did we all fall for this? The person who made this post, is obviously joking...
Check the nickname, and the smiley besides the 'i am a noob'
And the biggest joke is the posted code.