Parallelogram

Ok so here's my problem I am trying to make a parallelogram with a stars(*). This is what I have so far

Code:

#include<stdio.h>

int main (){

int numrow, numcols, i,;

printf("Enter the length of your figure:\n");
scanf("&#37;d", &numcols);


printf("Enter the width of your figure\n");
scanf("%d", &numrow);


while(numrow>0)
for(i=0; i<numcols;i++){
              for(i=0; i<numcols; i++)
              {
               printf("*"); 
                 
                }
                                    
                   
                   
          printf("\n");
                  
          
                        
        numrow--;
        
         }

Now that gets the width and length correct but I can input the spaces to make it offset like this.
*****
_*****
__*****
___*****

I know i need a loop to print the spaces but i dont know where to put it or how to word it any help would be great!.

Thanks

your loops are wrong - first should be on rows, second on colums

Code:

for(row=0; row<numrows;row++)
{
   /* spaces */
   for(col=0;col<row;col++)
      printf(" ");

   /* stars */ 
   for(col=0; col<numcols; col++)
   {
         printf("*"); 
   }

   /* end of line */              
   printf("\n");
}

uh ? clipsit your code will not get compiled. There is no closing '}' or return 0;

Code:

#include<stdio.h>

int main (){

int numrow, numcols, i;

printf("Enter the length of your figure:\n");
scanf("%d", &numcols);


printf("Enter the width of your figure\n");
scanf("%d", &numrow);


while(numrow>0)
for(i=0; i<numcols;i++){
              for(i=0; i<numcols; i++)
              {
               printf("*"); 
                 
                }
                                    
                   
                   
          printf("\n");
                  
          
                        
        numrow--;
        
         }
        
                                   

system("pause");
return 0;

this line

Code:

for(i=0; i<numcols;i++){

does nothing good for you due to duplicated code in the next line

this keeps saying syntax error what am I doing wrong?

Code:

#include<stdio.h>

int main (){

int numrows, numcols,row,col;

printf("Enter the length of your figure:\n");
scanf("%d", &numcols);


printf("Enter the width of your figure\n");
scanf("%d", &numrows);


for(row=0; row<numrows;row++);
{
   /* spaces */
   for(col=0;col<row;col++)
      printf(" ");

   /* stars */ 
   for(col=0; col<numcols; col++)
   {
         printf("*"); 
   }

                                   

system("pause");
return 0; }

I fixed the syntax but now it doesnt print the parallelogram anymore. With that new code it only prints one line of stars

Its easier for me to write my own code than to try figuring out what someone is trying to do with his/her code. So here is your code, edited, and running. I just commented out what i didn't like and wrote my own piece of code for that.

Code:

#include<stdio.h>
#include<stdlib.h>
int main ()
{

int numrows, numcols,row,col,spaces;

printf("Enter the length of your figure:\n");
scanf("&#37;d", &numcols);


printf("Enter the width of your figure\n");
scanf("%d", &numrows);


/*for(row=0; row<numrows;row++);
{
    spaces 
    for(col=0;col<row;col++)
            printf(" ");

    stars  
   for(col=0; col<numcols; col++)
   {
         printf("*"); 
   }

                                   

*/

for(row=1;row<=numrows;row++)
{
         printf("\n");
         for(spaces=0;spaces<row-1;spaces++)
              printf(" ");
         for(col=1;col<=numcols;col++)
              printf("*");
}                            
system("pause");
return 0;
 }

Originally Posted by clipsit

this keeps saying syntax error what am I doing wrong?

Code:

#include<stdio.h>

int main () {

   int numrows, numcols,row,col;

   printf("Enter the length of your figure:\n");
   scanf("&#37;d", &numcols);


   printf("Enter the width of your figure\n");
   scanf("%d", &numrows);


   for(row=0; row<numrows;row++);  /* <==get rid of this semi-colon */ 
   {
       /* spaces */
       for(col=0;col<row;col++)
          printf(" ");

       /* stars */ 
       for(col=0; col<numcols; col++)
          printf("*"); 

       printf("\n");
   }   
                                 

   system("pause");
   return 0; 
}

Just another note: the width of an array is the number of columns, not rows, the length of the array is the number of rows, not columns. No harm done, except the confusion, here.

Edit: Good one, Vart! We shouldn't assume that he knows he needs a newline at the end of each row, should we?

And where is the endline print-out?

Originally Posted by clipsit

this keeps saying syntax error what am I doing wrong?

Code:

#include<stdio.h>
#include<stdlib.h> /*for system("pause")*/
int main (){

int numrows, numcols,row,col;

printf("Enter the length of your figure:\n");
scanf("&#37;d", &numcols);


printf("Enter the width of your figure\n");
scanf("%d", &numrows);


for(row=0; row<numrows;row++);
{
   /* spaces */
   for(col=0;col<row;col++)
      printf(" ");

   /* stars */ 
   for(col=0; col<numcols; col++)
   {
         printf("*"); 
   }

} /*You forgot this brace*/               

system("pause");
return 0; }

and of course the logic for printing the parallelogram is wrong.

Originally Posted by abk

and of course the logic for printing the parallelogram is wrong.

Logic is OK, end line printing is missing

Originally Posted by vart

Logic is OK, end line printing is missing

Yeah! I guess printing the end line is a part of the "logic" ?? I think I should have said "logic is incomplete"

Thanks abk that really makes since now. I actually am a brick trying to learn C... appreciate the help!

Originally Posted by clipsit

I actually am a brick trying to learn C...

There is only one brick here in Cboard and that's me. Now just don't steal my signature ok