Problem's here!! Please help!!

[catcat28]

I am working on a program that can count the capital letters of the text file inputted.
However, sometimes it works and sometimes it doesn't. So i want to ask wt is the problem with my program.

 
   void capital(FILE*fp)   
{    
   char ch;    
   int count=0;          
   while(ch!=EOF)   
{    
    ch=fgetc(fp);    
    if(ch>='A' && ch<='Z')    
    count++;   
}     
    printf("\nThe total number of capital letters is %d.\n",count);    
    printf("\n");    
    fclose(fp);   
}

Please help!

[laserlight]

The first problem is with your code indentation. I suggest writing it as:

void capital(FILE *fp)
{
    char ch;
    int count = 0;
    while (ch != EOF)
    {
        ch = fgetc(fp);
        if (ch >= 'A' && ch <= 'Z')
            count++;
    }
    printf("\nThe total number of capital letters is &#37;d.\n", count);
    printf("\n");
    fclose(fp);
}

Now, since you have not given any sample data as to when it does not work, I can only guess: perhaps this is due to the fact that fgetc() returns an int, but you are storing its return value in a char. Along this line, fgetc() returns EOF when an attempt is made to read at the end of file, so on the last iteration you would well be comparing with EOF.

A far less likely reason is that the comparison ch >= 'A' && ch <= 'Z' does not work in determining uppercase characters, and theoretically it is not guaranteed to work, so you should use isupper() from <ctype.h> instead.

Consequently, you could try changing to:

    int ch;
    int count = 0;
    while ((ch = fgetc(fp)) != EOF)
    {
        if (isupper(ch))
            count++;
    }

One last note: it may be a better idea to let the caller close the file. After all, the caller opened the file, so the caller would expect to close it.

[pankaj401]

    char ch;
    int count = 0;
    while (ch != EOF)

You are reading ch without initializing. This could also be one of the reasons for your code not working.

[zacs7]

EOF also doesn't fit in a char.