Separate info in a txt file and put it into variables

[Netflyer]

I need help with reading text in a file and then putting it into variables.
Like say this is a line of text in the file
#Mike#12/05/1971#555678#Coment about this person#

Now I have created a struct:

typedef struct {
        char name[MAX_PESSOA];
        char phone[MAX_TELE];
        int day;
        int month;
        int year;
        int num[QTD]; // if the person has more than one phone number
        char text[MAX_TXT];
        } Person;

Person Contacts[NUM_PEOPLE];

FILE *eoftest;
    int i, ending=0;
    Person lines[512];
      eoftest=fopen("contactos.txt","r");      
      while((fgets(&lines,512,eoftest))!=NULL) 
 
      { 
 
      ending++;        
 
      }
      fclose(eoftest);
 
      eoftest=fopen("contactos.txt","r"); 
             
             for(i=0;i<ending;i++)
             {
                               
               fgets(&lines[i],512,eoftest);
              
               Contacts[i]=lines[i];
                           


  
  
}
fclose(eoftest);

Ok so this code works in the following manner it loads a whole line into each position of my array Contacts, but there is a problem I want to load each pseudo field "name" "day/month/year" etc.... from each line of the file into the variables of my struct
example line:

//example code I know I will need a loop to go through all the lines in the txt file.
Contacts[1].name='mike'; Contacts[1].day=23; Contacts[1].month=5

...etc
#Mike#12/05/1971#555678#Coment about this person#

Can someone please help me with this....

Thanks in advance :-)


P.S:Please don't look at indentation and stuff like that cause I am just trying right now to get this right then I will fix everything. Bye the way this is a project and I have to kinda follow this kind of idea of the line being Separated by the # but if any one has a different suggestion that will still load the "fields" that is fine :-)

[Elysia]

Person Contacts[NUM_PEOPLE];

    Person lines[512];

So what's the point of having two of the same type arrays? Read into Contacts if you're just going to assign them later.

      eoftest=fopen("contactos.txt","r");

You don't check if the open fails. Do that; otherwise you'll probably get yourself a crash if it fails to open.

      while((fgets(&lines,512,eoftest))!=NULL)

And what, exactly, do you think this does?
512 is the number of objects you have in your array, but fgets read a LINE.
Further, you are reading a LINE in text and not binary, so this is not what you should do. Not at all.
&lines is also incorrect. It should be &lines[0] or lines.

      eoftest=fopen("contactos.txt","r"); 
             
             for(i=0;i<ending;i++)
             {
                               
               fgets(&lines[i],512,eoftest);
              
               Contacts[i]=lines[i];

Repetition of your old loop except you assign to Contacts now.

Ok so this code works in the following manner it loads a whole line into each position of my array Contacts, but there is a problem I want to load each pseudo field "name" "day/month/year" etc.... from each line of the file into the variables of my struct
example line:

//example code I know I will need a loop to go through all the lines in the txt file.
Contacts[1].name='mike'; Contacts[1].day=23; Contacts[1].month=5

...etc
#Mike#12/05/1971#555678#Coment about this person#

Can someone please help me with this....

Thanks in advance :-)

You really need to read up on your skills some. You shouldn't read directly into a a struct at all unless you use binary, which you don't.
Due to the nature of your file, you might use fscanf or some similar function (I'm not an expert at that) to read until you hit a '#' or something like that.

P.S:Please don't look at indentation and stuff like that cause I am just trying right now to get this right then I will fix everything. Bye the way this is a project and I have to kinda follow this kind of idea of the line being Separated by the # but if any one has a different suggestion that will still load the "fields" that is fine :-)

Indentation is more important than your program. Fix it FIRST, THEN fix the code. Indentation is supposed to HELP you find bugs, NOT create them.
Indent as you type.

[cpjust]

You need to convert text into ints. Try atoi() for a single number, or sscanf() for more complex parsing of multiple variables...

[Elysia]

strtol is better than atoi

[Netflyer]

Why do you recomend converting text into ints?
What are the advantages?
Can you explain please?

Thanks

[Elysia]

Because you're reading a string with fgets and int != string.

[IceDane]

strtol is better than atoi

If you read the source, you'll see how atoi is just a wrapper function for strtol.

[Elysia]

The runtime is implementation defined.
That means atoi may or may not call strtol depending on who created the library.

[cpjust]

strtol is better than atoi

Why?

[Elysia]

Matsp summed it up nicely once:
http://cboard.cprogramming.com/showp...34&postcount=4

[cpjust]

I don't really know why they wrote those functions in such a sloppy way to begin with. You'd think they would have done something like:

int atoi( const char* str, int* num, int base )

Then they can just return a 0 or 1 if the function failed or not (or even better, just return the errno)...

[Elysia]

True. Standard API way. C runtime is flawed

[BobS0327]

Can someone please help me with this....

Here's a sample.

#include <stdio.h>
#include <string.h>

#define  MAX_PESSOA 128
#define MAX_TELE    37
#define QTD 3
#define MAX_TXT  128

typedef struct {
    char name[MAX_PESSOA];
    char phone[MAX_TELE];
    int day;
    int month;
    int year;
    int num[QTD]; // if the person has more than one phone number
    char text[MAX_TXT];
} Person;

int writeacoupleofrecords(char *fname)
{
    Person contacts;
    FILE *writefile;
    writefile=fopen(fname,"ab");  // Append records
    if (!writefile)
        return 1;
    strcpy(contacts.name, "Bob S.");
    strcpy(contacts.phone, "570-555-1212");
    contacts.day = 24;
    contacts.month = 12;
    contacts.year = 2007;
    contacts.num[0] = 1;
    strcpy(contacts.text,"text1 message");
    fwrite(&contacts,sizeof(Person),1,writefile);       

    strcpy(contacts.name, "Ted F.");
    strcpy(contacts.phone, "570-555-1313");
    contacts.day = 11;
    contacts.month = 9;
    contacts.year = 1989;
    contacts.num[0] = 1;
    strcpy(contacts.text,"text2 message");
    fwrite(&contacts,sizeof(Person),1,writefile);
    fclose(writefile);   
    return 0;
}

int readtherecords(char *fname)
{
    FILE *readfile;
    Person contacts;
    readfile=fopen(fname,"rb");
    if (!readfile)
        return 1;
    while(fread(&contacts, sizeof(Person),1, readfile) == 1)
    {
        printf("%s %s %02d %02d %d %d %s\n",
            contacts.name,contacts.phone,contacts.day,contacts.month,contacts.year,contacts.num[0],contacts.text);
    }    
    fclose(readfile);
    return 0;
}

int main(void)
{
    if(!writeacoupleofrecords("contacts.txt"))
        readtherecords("contacts.txt");
    else printf("writeacoupleofrecords failed\n");
    return 0;
}

[Netflyer]

Thanks Bob... for the help :-)