what's the problem with this code?

[abh!shek]

It is supposed to write to a file..........

#include<stdio.h>
int main()
	{
	FILE *fp;
	char string[50];
	fp=fopen("C:\\test.txt","w");
	printf("\n\nEnter a few lines\n\n");
	while(strlen(gets(string))>0)
		{
		fprintf(fp,string);
		fprintf(fp,"\n");
		}
	getch();
	}


[MacGyver]

The problems are as follows:

• You're not checking to see if fp is NULL before you use it.
• You use gets().
• You use getch().
• Even with using getch(), you don't include conio.h.

Overall, the code sucks.

[Aia]

fprintf(fp, "%s",string);
fprintf(fp, "%s","\n");


example

[Elysia]

Use fgets instead of gets and check for error on fgets return.
You should also explicitly return 0 at the end of main.

[ssharish2005]

And I guess u are using one of these ancient 16bit turbo C compiler. And hence you are coming up with just a solution which is no more accpetable under ISO C standard. Use GCC.

If you are on windows use DEV-C++.

ssharish

[Elysia]

Or Visual Studio 2008 Express