Thread: Repetitive data (Noob)

Yes.

use a initializer, e.g.:

Code:

const struct category cat[4] = { { 1, "Text1", 0.11 }, 
                                          { 2, "Text2", 0.22 },          
                                          { 3, "Text3", 0.33 },          
                                          { 4, "Text4", 0.44 } };

--
Mats

I must implement this next. Why wont my displays work will someone tell me? Everything is compiling correct and all but it wont print the data for me. Please help!!!

Code:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include <errno.h>


struct category
{
	int id;
	char description[25];
	float vatrate;
	
};

struct product
{
	
	char  productname[25];
	float price;
	int catid;
	
};

typedef struct product P;
typedef struct category C;

void welcome();
int basket(C array1[], P array2[]);
void till(int num,P array2[]);

int main()
{
	int k = 0;
	int i = 0;
	int size;

	const int limit = 10;

	C cat[limit];
	P prod[limit];

	welcome();
	
	for (k; k<4; k++)
	{
		printf ("Please enter the category code\n");
		scanf("&#37;d", &cat[i].id);
		
		printf ("Please enter the category description\n");
		scanf ("%s", cat[i].description);
		
		printf ("Please enter the category VAT rate\n");
		scanf ("%f", &cat[i].vatrate);
		
		system ("cls");
	}
	printf("Category Code\t\tCategory\t\t\t\tVAT%\n");
		
	for(i;i<4;i++)
	{
		printf("%d\t\t\t%s\t\t\t\t%f.1f\n\n",cat[k].id,cat[k].description,cat[k].vatrate);
	}
	
	size=basket(cat,prod);
	till(size,prod);
}
 


int basket(C array1[], P array2[])
{
	int k, num=0, code;
	
	printf ("How many items are being purchases\n");
	scanf ("%d", &num);
	
	for(k=0;k<num;k++)
	{
		printf("Please enter product name\n");
		scanf ("%s", array2[k].productname);
		
		printf ("Please enter a price of the product\n");
		scanf("%f", &array2[k].price);
		
		printf ("Please enter the category code\n");
		scanf ("%d", &code);
		
		array2[k].catid = array1[ code ].vatrate;
	}		
	
	if(code>3||code<0)//if the user types in an invalid category code it prints out this message	
	{
		printf("No such code exists");		
	}
	
	return num;
}


void till(int num,P array2[])
{
		int q=0;
	float vat;//the actual vat due is stored here
	float cost;//this is the total cost
	
	
	printf("Item\t%VAT\tActual Vat\tCost\n");
	
	for(q;q<num;q++)//this for loop calculates the vat rate and prints out a table of information
	{
		vat=((array2[q].price/100)*array2[q].catid);//this calculates the vat due from each product
		cost=(vat + array2[q].price);//this calculates the total cost of each product including VAT
		printf("%s\t%2.0f\t%2.2f\t\t%3.2f\n",array2[q].productname,array2[q].catid,vat,cost);		
	}
}


void welcome()
{
	printf ("\t\t\tWelcome\n");
}

Code:

for (k; k<4; k++)
{
printf ("Please enter the category code\n");
scanf("&#37;d", &cat[i].id);

printf ("Please enter the category description\n");
scanf ("%s", cat[i].description);

printf ("Please enter the category VAT rate\n");
scanf ("%f", &cat[i].vatrate);

system ("cls");
}

In the above for-loop, you never initialize k, so it starts at some unknown value. In addition k is your loop variable so why are indexing the array with i instead? To give k some initial condition (like 0), use:

Code:

for (k=0; k<4; k++)

Code:

for(i;i<4;i++)
{
printf("%d\t\t\t%s\t\t\t\t%f.1f\n\n",cat[k].id,cat[k].description,cat[k].vatrate);
}

size=basket(cat,prod);
till(size,prod);
}

In the above for-loop i is never initialized. And you use k versus i to index the array.

Actually it looks like you did initialize k and i when you declared them, but it's better to initialize them inside the for-loop construct.

>Also how can i call the struct like matsp said into my program to auto load the data?
Just substitute the line matsp posted in place of this line at the top of main():

Code:

C cat[limit];

You can verify the values are stored there by printing them as you do now.

>i dont understand. How can this hold my constant 4 values? they will always be

Code:

C cat[limit] = { { 1, "hardware", 21 }, 
                        { 2, "electrical", 21 },          
                        { 3, "appliance", 18 },          
                        { 4, "food", 0 } };

>Have you any idea why that last function is printing jibberish?
You'd need to post the latest code. Assuming you fixed the for-loop problems above, you might try making sure all scanf()'s are succeeding (scanf() will return how many items it was able to read, probably a 1 in your case). If it returns something besides 1, then the read was unsuccessful.

Code:

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include <errno.h>


struct category
{
	int id;
	char description[25];
	float vatrate;
	
};

struct product
{
	
	char  productname[25];
	float price;
	int catid;
	
};

typedef struct product P;
typedef struct category C;

void welcome();
int basket(C array1[], P array2[]);
void till(int num,P array2[]);

int main()
{


	int k = 0;
	int i = 0;
	int size;

	const int limit = 10;

	C cat[limit] = { { 0, "Hardware", 21 }, 
                                   { 1, "Electrical", 21 },          
                                   { 2, "Appliance", 18 },          
                                   { 3, "Food", 0 } };


	P prod[limit];

	welcome();
	
	printf("Category Code\t\tCategory\t\t\t\tVAT&#37;\n\n");
		
	for(i=0;i<4;i++)
	{
		printf("%d\t\t\t%s\t\t\t\t%2.1f\n\n",cat[i].id,cat[i].description,cat[i].vatrate);
	}
	
	
	size=basket(cat,prod);
	till(size,prod);
}
 


int basket(C array1[], P array2[])
{
	int k, num=0, code;
	
	printf ("How many items are being purchases\n");
	scanf ("%d", &num);
	
	for(k=0;k<num;k++)
	{
		printf("Please enter product name\n");
		scanf ("%s", array2[k].productname);
		
		printf ("Please enter a price of the product\n");
		scanf("%f", &array2[k].price);
		
		printf ("Please enter the category code\n");
		scanf ("%d", &code);
		
		array2[k].catid = array1[ code].vatrate;
	}		
	
	if(code>3||code<0)//if the user types in an invalid category code it prints out this message	
	{
		printf("No such code exists");		
	}
	
	return num;
}


void till(int num,P array2[])
{
	int q=0;
	float vat;//the actual vat due is stored here
	int cost;//this is the total cost
	
	
	printf("Item\t%VAT\tActual Vat\tCost\n");
	
	for(q=0;q<num;q++)//this for loop calculates the vat rate and prints out a table of information
	{
		vat=((array2[q].price/100)*array2[q].catid);//this calculates the vat due from each product
		cost=(vat + array2[q].price);//this calculates the total cost of each product including VAT
		printf("%s\t%2.0f\t%2.2f\t\t%3.2f\n",array2[q].productname,array2[q].catid,vat,cost);		
	}
}


void welcome()
{
	printf ("\t\t\tWelcome\n\n");
}

Thats for last piece. worked a dream man. Just the receipt printing now to fix. Why does it keep giving me 0 vales for vat, actual vat and cost?

Maybe catid never got stored, as this looks suspicious:

Code:

array2[k].catid = array1

It's impossible to tell the way the code is pasted.

The formatting gets confused by the code containing an index into an array, where the index is called code. Unfortunately, hard to fix, aside from changing the name of the variable code. This obviously have no impact on the actual function of the program.

Now onto the program itself:

Code:

printf("%s\t%2.0f\t%2.2f\t\t%3.2f\n",array2[q].productname,array2[q].catid,vat,cost);

How about matching the type with the output format?

Also, this bit:
array2[k].catid = array1[code].vatrate;
Assigns a float to an integer.

--
Mats

PS
Don't use 'code' as an array subscript, it confuses the code tags!