Thread: number is showing as 2?

This program is supposed to count the number of letters, punctuations and numbers a user enters.

The problem I'm having is that "letter" is showing as 2 when I only type in 1 letter. If I assign letter to -1, then it all works fine. So what is wrong here?

Code:

#include <stdio.h>
#include <conio.h>

int main(void)
{
    char ch;
    int digit, punc, letter;
    
    printf("Enter number, punctuation or letter: \n");
    
    digit = 0;
    punc = 0;
    letter = 0;
    
    do {
    ch = getche();
    switch(ch) {
    
        case '0':
        case '1':
        case '2':
        case '3':
             case '4':
                  case '5':
                       case '6':
                            case '7':
                                 case '8':
                                      case '9':
                                           digit++;
                                           break;
                                           
        case '.':
             case ',':
                  case '?':
                       case '!':
                            case ':':
                                 case ';':
                                      punc++;
                                      break;
                                      default:
                                              letter++;
                                              }
                                              
                                              } while(ch!='\r');
                                              
                                              printf("\nDigits: %d\n", digit);
                                      printf("Punctuation: %d\n", punc);
                                              printf("Letters: %d\n", letter);
                                              
                                              getche();
                                              }

I'm not to sure what you mean, I type in the letter 'a' and then press enter. Then it sais:

letters: 2

Originally Posted by Aia

Exactly, two characters: 'a' and 'newline'.

char ch should be int ch since you have to make accommodation for the possibility that getche() would return an EOF which is an integer.

Okay, I changed char ch to int ch and nothing changed.

you need a case '\n': break;

Originally Posted by Doodle77

you need a case '\n': break;

Where do I put this?

I've tried it a couple places and its either changing it so the number value is 0, or 2

Originally Posted by Aia

[Edit]: right before the default after the punc, break

Code:

case '\n':
case '\r':
     break;

thanks you kind user