Thread: Best way to call a subroutine

I am writing a program that uses 20 different case options to modify outportb values. The subroutine converts Hex to decimal, and used often. I don't want to add the subroutine in each case selection. Here is what I was thinking of, but I am not quite sure how to do it. Can I have a separate program after the end of the main program? Or should I use an #include?

Code:

main()
{
case '1':

// call H2D 

H2D;

break;

case '2':

H2D;

break;

etc.

} // end main

// Hex to Decimal conversion

H2D()
{

program lines .......

} // end H2D

are you asking how to use functions?

So for each case that needs that convert function, you want to just have the code added:

convert(whatever parameters you need here);

Saves a lot of space and helps keep everything organized.

I am just asking if the syntex look correct.
I know the function works fine. but is this the correct way to call the subroutine?

No.

Code:

void your_func() { }
int main()
{
	your_func();
	return 0;
}

Always included paranthesis, and pass arguments if needed.
Your function also lacks return type.

Originally Posted by N3BPM

I am just asking if the syntex look correct.
I know the function works fine. but is this the correct way to call the subroutine?

i can see u are trying to use switch statment over there. which should be

Code:

main()
{   
       switch (ch)   
      {       
          case '1':          
                 // call H2D            
                 H2D;     
                 break;    
          case '2':   
                H2D;  
                 break; 
          etc.   
     }
}

ssharish

Originally Posted by N3BPM

I am writing a program that uses 20 different case options to modify outportb values. The subroutine converts Hex to decimal, and used often. I don't want to add the subroutine in each case selection. Here is what I was thinking of, but I am not quite sure how to do it. Can I have a separate program after the end of the main program? Or should I use an #include?

Code:

int main()
{
	switch(something)
	{
		case '1':
			// call H2D 
			H2D();
			break;
		case '2':
			H2D();
			break;
			//etc.

	}
} // end main

// Hex to Decimal conversion

void H2D()
{
	//program lines .......
} // end H2D

Come on, it's not like we read gibberish that doesn't even ident. Don't forget a closing bracket for your switch.
main should ALWAYS return int. See FAQ.
Function calls is name_of_function(arguments);
Yes, you also forgot to add a switch statement to switch for something.
All functions need to return a value (if not, use void). I highlighted things I added in red.

You didn't specify whether anything different was happening for each of those cases, so if they all do the same thing, you could save time & space by doing this:

Code:

switch( ch )
{
case '1':
case '2':
case '3':
case '4':
    H2D();
    break;

default:
...
}