Code is hanging - Very simple C (Beginner)

Hi,

Im trying to get this program to run - it complies but it crashes in DOS. It is down to the Stuname i think, or maybe having two print F's. Hope you can help.

Jon

Code:

#include <stdio.h>

main()

{
      int stuname, mathsmark, englishmark, overallgrade;
      
      /*get marks */
      
      printf("What is your name\n");
      scanf("%s", stuname);
      
      printf("Please key in your maths mark\n");
      scanf("%d", &mathsmark);
      
      printf("Please key in your english mark\n");
      scanf("%d", &englishmark);
      
      
      /*Calculate total mark*/
      overallgrade = mathsmark + englishmark;

      /*display total mark*/

      printf("your total mark", stuname);
      printf("is %d", overallgrade);

      return 0;
}

printf("your total mark", stuname);

it's missing something

Originally Posted by indigo0086

printf("your total mark", stuname);

it's missing something

Is this it? As it didn't work with this as well.

Code:

printf("your total mark%s", stuname);

> printf("What is your name\n");
> scanf("%s", stuname);
stuname should be declared as a char array. And you might consider using fgets() instead of scanf() for reading it.

Code:

int stuname, mathsmark, englishmark, overallgrade;
      
/*get marks */
      
printf("What is your name\n");
scanf("%s", stuname);

WTF

New code:
But still crashing after entering a name(stuname).

Code:

#include <stdio.h>

main()

{
      int mathsmark, englishmark, overallgrade;
      char stuname[50];
      
      /*get marks */
      
      printf("What is your name\n");
      scanf("&#37;s", stuname);
      
      printf("Please key in your maths mark\n");
      scanf("%d", &mathsmark);
      
      printf("Please key in your english mark\n");
      scanf("%d", &englishmark);
      
      
      /*Calculate total mark*/
      overallgrade = mathsmark + englishmark;

      /*display total mark*/

      printf("your total mark %s", stuname);
      printf("is %d", overallgrade);

      system("PAUSE");
      
      return 0;
}

scanf() stops when it sees whitespace, so if the name entered contains spaces, you'll have to either use two scanf()'s, or use fgets() to read a line of text.

>scanf() stops when it sees whitespace
Actually, scanf() ignores whitespace.

As swoopy said, use fgets().

It works now - It was because Vista must have been blocking something, because it works in XP now.
What programs etc do you use for C programming?

Originally Posted by zacs7

>scanf() stops when it sees whitespace
Actually, scanf() ignores whitespace.

Well, it ignores it by "stopping," i.e. finishing the current conversion. Hitting whitespace doesn't stop the entire call to scanf() though.

>What programs etc do you use for C programming?
A text-editor (SciTE), and a compiler.