Thread: Next question

Well you're comparing before inputting anything.

Also, fold your long printf lines like this

Code:

printf( "This is a long line\n"
        "And this is another line" );

Also, you don't need the & when using %s to scan into a char array (it's the exception to the rule).

> while (strcmp(selection,"Q")!=0)
What does selection contain the first time around?
- an empty string
- your input
- random garbage

Originally Posted by kiz

where does the "random garbage" come from?? so how do i fix it?

Non-global variables (those local to a function) will contain "garbage" if the variable isn't set to something in particular.

Code:

   char selection[2] =  {0 };

As an example.

--
Mats

Whilst setting your array to "aa" would essentially fix the problem of "random garbage", it is also invalid, becuse "aa" is three bytes long, your array is only two bytes. Remember, C strings have a "end marker" which is zero, so "aa" is 'a', 'a', 0 - three characters.

--
Mats

Originally Posted by kiz

i tried intialising it as 'a' aswell

let try and explain wat isnt working again if it didnt seem clear

these things happen in the program

case 1

1. I run program
2. I enter 'Q' at menu selection
3. Program ends

case 2

1. I run program
2. I enter '1' at menu selection
3. I enter my name
4. program loops back to menu selection
5. i enter 'Q'
6. program loops back to menu selection rather than end

why wont it end in case 2???

Because fscanf() is "stupid" when it comes to reading in strings - this is _ONE_ of many reasons not to use it. It reads a line of text (in the case of "%s") until the first "whitespace", such as newline (from the "enter" key), leaving that whitespace in the input buffer. Next time round, it sees the newline and returns to you with an empty string, because the newline hasn't been read yet. You need to flush the input buffer - check the FAQ for how to "clear the input buffer" [DO NOT USE fflush(input), as that is definitely NOT the right thing to do, check the FAQ on the top of these pages to see why].

--
Mats