string array arithmetic

[qubit67]

I am trying to disscet this string into 2 parts at the char ';'

"crafted;def6049"

the strlen of this is 15

 phrase_len = strcspn (buffer, ";");

phrase_len = 7

 phrase = (char *) safe_malloc ((phrase_len + 1) * sizeof (char));

Am i right to malloc for the extra byte concerning the NULL?

Wont this create a string array starting at 0 finishing at 8 and then if i copied "crafted" to phrase, I would be left with 2 spaces at the end instead of one for the null.

Is that right?

[matsp]

 0   1   2   3   4   5   6   7
'c' 'r' 'a' 'f' 't' 'e' 'd' '\0'

8 bytes is what you need, and they are numbered 0..7.

malloc counts the number of bytes, so 8 would be the correct value. You can check this by adding one extra byte, and assign this to some value, such as 0xAA, then check that you have 0x00, 0xAA at after the 'd' in the above string.

--
Mats

[qubit67]

thanks for the explainantion