Thread: what is better to use while or for

hello ,...

im reading smser (smser.sf.net)project i added few docs and i thought going tru the code and maybe i could help the orihnal programer (i actualy thound few things that could make the program better but still ... )

in the code there is a

Code:

while (fgets(s,MAXLINELENGTH,f)!=NULL)
    	{
    	//handle line of file
    	strcpy(&a[i* MAXNUMLENGTH],s);
        i++;
    	}

im thinking that it will be better to do :

Code:

for (i = 0 ; fgets(s,MAXLINELENGTH,f)!=NULL ; i++ ) 
{
    strcpy(&a[i* MAXNUMLENGTH],s);
}

Either is really quite acceptable. Some people frown at using a condition in a for-loop that is completely unrelated to the variable in the iteration itself. But that's one of those things that can be debated either way. Modern compilers will probably generate identical code for both choices.

--
Mats