Thread: replace the "*" in the above string with " ", a single space character using ANSI C??

sorry this one is rite.

Code:

#include <stdio.h>
#include <string.h>

char * foo = " Baltimore *MD*is*a*really*good*place*to*work*and*play";

int main(void){

for (int i=0 ; i<strlen(foo) ; i++)
    if (foo[i]=='*')
        foo[i]=' ';

return 0;
}

try running it.

Originally Posted by maxorator

Lol, what's wrong with mine?

Nothing, it's better than obaid's in the sense that using strlen as part of a for-loop end-check is a bad thing - especially when the string is being modified inside the loop, as the compiler may not realize if that the length is constant, and thus call strlen EVERY single iteration of the loop.

--
Mats

obaid's code is modifying a string literal too which are constant.

Why are there no standard restrictions on modifying string literals?

Originally Posted by Smiley10

obaid's code is modifying a string literal too which are constant.

Why are there no standard restrictions on modifying string literals?

In trivial cases, it would be possible for the compiler to detect it, but in anything but trivial cases (e.g. when a function takes a char * as a parameter, and that char * happens to be a pointer to a literal).

It's not just obaid's code that does so, by the way, several of the other examples do too. Maxorators doesn't - but it also doesn't match the original poster's question - and by the way, we haven't seen any post from the OP for a while.... Perhaps the lesson ended? :-)

--
Mats

Originally Posted by matsp

In trivial cases, it would be possible for the compiler to detect it, but in anything but trivial cases (e.g. when a function takes a char * as a parameter, and that char * happens to be a pointer to a literal).

It's not just obaid's code that does so, by the way, several of the other examples do too. Maxorators doesn't - but it also doesn't match the original poster's question - and by the way, we haven't seen any post from the OP for a while.... Perhaps the lesson ended? :-)

--
Mats

Thank you.

Code:

#include <stdio.h>
#include <string.h>

int main (int argc, char* argv[])
{
    
    char *foo = "Charlotte *NC*is*a*really*cool*place*to*work*and*play";
    char *bar = strdup (foo);
    char baz [] = "Charlotte
*NC*is*a*really*cool*place*to*work*and*play";
    char *replace = baz;
    printf ("&#37;s\n", baz);
    while (*replace)
    {
        if (*replace == '*') *replace = ' ';
        replace++;
    }

    printf ("%s\n", baz);
	return 0;
}

well maxotator, your code gives correct result but it changes the requirement, i think i would have to use the secondary buffer no matter what, as zacs said i am trying to remove foo and bar, and use char buf[100] as a secondary buffer, i will post back if i succeed, if anyone else can plz let me know

Okay this is as close as you'll get...

Code:

#include <stdio.h>
#include <string.h>

int main(void)
{
    char foo[] = " Charlotte *NC*is*a*really*cool*place*to*work*and*play";
    size_t  i = 0,
            len = strlen(foo);
    for(i = 0; i < len; i++)
    {
         /* foo[i] contains the current character, what should I do with it!?!? */
    }

    /* I should probably print foo here... */
    return 0;
}

Now it's up to you to complete it and trim it down, it can be written in less code (ie with less variables and less statements... I've merely shown you how to step through foo char-by-char nothing more, nothing less.




well wont i have to store foo in secondary buffer first? since i cant move/edit original one? what else can i use besides strdup to ease the process?

Originally Posted by obaid

sorry this one is rite.

Code:

#include <stdio.h>
#include <string.h>

char * foo = " Baltimore *MD*is*a*really*good*place*to*work*and*play";

int main(void){

for (int i=0 ; i<strlen(foo) ; i++)
    if (foo[i]=='*')
        foo[i]=' ';

return 0;
}

i tried running it, unsuccessful attempt tho

Code:

#include<stdio.h>
#include<string.h>
int main()
{
 char *foo = "Charlotte*NC*is*a*really*cool*place*to*work*and*play"; 
 char buf[100];
 int l = strlen(foo);
int i;

 for(i=0;i<l;i++)
 {
  
        if(*foo=='*')
   buf[i] = ' ';
  else
   buf[i] = *foo;
        *foo++;
  
 }
 for(i=0;i<l;i++)
  printf("%c",buf[i]);
  printf("\n");
  getchar ();
}

check it out guys, how u like it?