Struct error

[sniper83]

I'm new in structs so this question might sound silly, but I cannot see the problem:

I'm defining a struct in the header. This is the struct:

// struct to sentencedata
struct sentencestruct {
	int numberOfSentences;
        char *sentenceArr[10000];
};

But when I'm trying to use it i get error-messages:

void speechrecognitioncontrol() {

int tempnt=0;
struct sentencestruct speechSentences;
signed int  pid;
int i;
....

Compiling gives this error:

control-module.c:380: error: storage size of 'speechSentences' isn't known


Somebody please help..

[Salem]

You need to include that header file in the source file which uses it.

[sniper83]

You need to include that header file in the source file which uses it.

I have done that.. But i might not have written extern struct ... (like other extern variables is defined) in the beginning, now you mention it.. I'll try it out right away..

[sniper83]

It don't seem to work.. in the beginning of the file is written:

Header:

// struct to sentencedata
struct sentencestruct {
	int numberOfSentences;
        char *sentenceArr[10000];
};

.c file:

#include "control-module.h"
extern struct sentencestruct;

....
void speechrecognitioncontrol() {

int tempnt=0;
struct sentencestruct speechSentences;
signed int  pid;
int i;
....

Now i only get one warning about this extern struct:
warning: useless keyword or type name in empty declaration
control-module.c:382: error: storage size of 'speechSentences' isn't known

[vart]

extern struct sentencestruct;

is just like
extern int;

it has no meaning

is this code

// struct to sentencedata
struct sentencestruct {
	int numberOfSentences;
        char *sentenceArr[10000];
};

located in the "control-module.h" header? or some other header?

[sniper83]

I know i has no meaning, but if its not defined as en extern ressource then it cannot refference it..

And no i is defined in global.h which is compiled together and all other variables in it is working fine.. But you caught the problem I think. Because after I tried to move it to my control-module header it can now find it; it seems at least at the moment.. Why can't I define this in the global header where all the files have access to. .?

[hk_mp5kpdw]

I know i has no meaning, but if its not defined as en extern ressource then it cannot refference it..

And no i is defined in global.h which is compiled together and all other variables in it is working fine.. But you caught the problem I think. Because after I tried to move it to my control-module header it can now find it; it seems at least at the moment.. Why can't I define this in the global header where all the files have access to. .?

Putting something in a header file means jack if the source file in question does not #include that header file. There is no global header file that is automatically accessed by all the source files. If the struct was defined in global.h then you should have #include'd global.h for the compiler to recognize the struct.

[sniper83]

It seem that I can make a struct.h and put all the structs in it, and then include this one in both c-files where i use them..

But now I get another error due to these. It complains about this line in one of the files:

struct sentencestruct speechSentences; 
...
speechSentences =	receiveMsgSpeechRecognition();

with this message:
control-module.c:518: error: incompatible types in assignment

but the metod is declared like this in the other one:

struct sentencestruct receiveMsgSpeechRecognition() { ... }

Doesn't it look right..? The sentencestruct now is defined in one header structs.h which is included in both files..

[sniper83]

Putting something in a header file means jack if the source file in question does not #include that header file. There is no global header file that is automatically accessed by all the source files. If the struct was defined in global.h then you should have #include'd global.h for the compiler to recognize the struct.

Thanks alot... But I have had no problems of the global variables.. :S Strange.. But I just included the global.h in all the files and now the other problem dissapered as well..

Thanks you all.. Great help..

[sniper83]

NO.. Maybe I was a litte fast.. The makefile just make it seem it was not there anymore.. It still exists.. :/
Help will be appresiated..

btw: All the extern references to the variables in the files i had in the header as it complaint about without extern, should i delete these..?

[hk_mp5kpdw]

Post all your files for this project you're working on as attachments and all the error messages reported by the compiler.

[sniper83]

Post all your files for this project you're working on as attachments and all the error messages reported by the compiler.

It seriously a lot of code.. And alone the two files we talk about is around 3000-4000 lines.. I tries to seperate the problem in two c-files wih only the nessasary methods and their headers and upload them in a couple of minutes..

[sniper83]

Okay.. Now I have seperated it.. Just run make, and you will see the problem.. EDIT: Cannot upload the makefile, but I uploads it in a second in makefile.h. Just erase the .h and run it.. Orelse the output is

[...Temp4]# make
cc -c -o control-module.o control-module.c
control-module.c: In function `speechrecognitioncontrol':
control-module.c:126: error: incompatible types in assignment
control-module.c:132: error: incompatible types in assignment
make: *** [control-module.o] Error 1

[sniper83]

And the makefile..

[hk_mp5kpdw]

Well, for the code you've provided, I also get undefined function messages for receiveMsgSpeechRecognition and also RecogniseWordInSentence which would account for those errors. If the compiler doesn't understand what those two functions are then it will assume they return an int and then you get the errors because it can't convert an int to type struct sentencestruct. So, where are the prototypes for those two functions located?

Also, instances of variables should be restricted to the source files and not put into headers like you've done in global.h. Header files should generally contain function prototypes and extern statements and struct definitions while the source file(s) that #include those headers contain the actual instances of any variables.