scanf is confusing me.

Hello,

First the code-

Code:

#include<stdio.h>

int main()
{

	char input;
	
	input = NULL;

	while(input != 'Q') {
		printf("Enter Letter:");
		scanf("%c", &input);
	}
	
	return 0;
}

I am very new to C but not new to programming (although it has been a long time since I did any of it). I have the K&R book and have found it to be as confusing as it is informative. Right now I am attempting the above as an exercise to control the return of the program. I have no idea if this is a very stupid way of doing it, but it's what I have managed so far.

The problem- Whenever I run this program it does as it should in my terminal window (I'm using a bash terminal on mac os x btw) and prints "Enter Letter:" to the screen and waits for my input. If I enter "Q" it exits the loop and returns the program perfectly. However, if I try entering any other type of data it newlines and prints "Enter Letter:" once, and then again for each character I have inputted.

For example-

Code:

Enter Letter:A

causes the next line to be

Code:

Enter Letter:Enter Letter:

I am figuring that the problem is my lack of understanding of how scanf actually works and I must admit I am a bit lost in how C seems to handle data. I have also tried getchar() and it gives the same result with the testing I have done so far.

Also, I am new to posting on message boards so I hope I have not posted anything incorrectly. Any tips for making my future postings easier for people to read are greatly appreciated.

Thank you to any and all who reply.

Babel

This has been asked quite a few times here. The ' \n' gets into the input buffer when you hit the enter key. That is why you are getting that kind of an output. It would be better to use fgetc() / fgets() to accept chars or strings from the user.

use getchar();
http://faq.cprogramming.com/cgi-bin/...&id=1043284351
http://faq.cprogramming.com/cgi-bin/...&id=1043284392
read the FAQ

also
input=NULL;
assignment makes integer from pointer without a cast
you cannot assign NULL to ordinary char like that

i think using do while statment is better to solve this problem if you don't know it send me a private email

guys wouldnt fflush(stdin) before the scanf solve the problem ??

I am no pro so feel free to flame me :P

guys wouldnt fflush(stdin) before the scanf solve the problem ??

From the FAQ: Explanations of Why fflush(stdin) is wrong.

So far the replies have been helpful, but I'm still having a hard time understanding how to make my wannabe command line work without breaking.

Basically, what I am trying to do is create a Sudoku game in a terminal window. Here is what I want the screen to look like.

Code:

     A   B   C   D   E   F   G   H   I
   *************************************
 A *   | 8 |   *   |   | 2 * 9 |   |   *
   *-----------*-----------*-----------*
 B *   |   | 6 * 5 | 3 | 8 *   |   | 1 *
   *-----------*-----------*-----------*
 C * 2 |   |   *   | 1 |   * 3 |   | 8 *
   *************************************
 D * 9 | 1 |   *   |   | 6 *   | 3 |   *
   *-----------*-----------*-----------*
 E *   |   | 7 *   | 4 | 1 *   |   |   *
   *-----------*-----------*-----------*
 F * 3 | 6 |   *   |   |   * 4 |   |   *
   *************************************
 G * 7 |   | 9 *   | 8 |   *   | 4 | 2 *
   *-----------*-----------*-----------*
 H * 6 |   |   * 1 |   |   *   | 7 |   *
   *-----------*-----------*-----------*
 I * 8 |   | 1 * 2 |   | 3 * 5 |   |   *
   *************************************

Enter command:

So Q will quit, S will save the puzzle, N will generate a new puzzle, or they can enter the vertical and horizontal coordinates along with a number between 1-9. Zero will delete a number if one is present. So for example AA1 puts a 1 in the box located at vertical A and horizontal A.

I have already got the puzzle grid to print and any other things I need to show up on the screen I know I can do. Where my problem has been is with the input at the game's pseudo command line. Anybody have any ideas on how to make this work?

Also, as I've been reading through the K&R book, the FAQs on here, and various other places I have realized it is not possible to do a refresh of a terminal window's screen using anything in the standard library. Having it reprint the puzzle continously down terminal kind of sucks, but if it's the only way then it's the only way.

babelosopher a terminal library will make your life a lot easier.

Windows: PDcurses (Ports to the X-terminal too)
*nix: nCurses

I think the problem is that scanf() reads the next character from the stream, which would be '\n'.

When you type anything other than Q, then press enter both characters are read by scanf.
e.g. The first time, it'll read T and only T. Then scanf will check the stream for any characters ready to be taken and find the '\n' you input to tell it to read the T.

I don't think I explained it in the best way possible, but I hope you understand.

As for how to fix it, I think another member would be able to help better than I can. I am not that experienced with C yet.

Personally I wouldent use scanf to get the input, I'd use fgets() instead. By getting th input as a sting first your program won't crash if the user enters something wrong by accident. You could then read the first three characters in sequence to represent something like:

- x position on grid
- y position
- number to change cell to

For drawing you grid theres also some ascii characters for borders you can use. Heres an example of a basic function I made to draw a grid for a chess board:

Code:

#include <stdio.h> 

void DrawBoard()
{
    for(int y=0; y<18; y++)
        for(int x=0; x<26; x++)
            if(y==0)
                if(x==25)       printf(" \n");
                else if(x%3==2) putchar(65+(x/3));   
                else            putchar(' ');
            else if (y==1)
                if(x==0)        putchar(' ');
                else if(x==1)   putchar(218);
                else if(x==25)  printf("%c\n", 191);
                else if(x%3==1) putchar(194); 
                else            putchar(196);
            else if(y==17)
                if(x==0)        putchar(' ');
                else if(x==1)   putchar(192);
                else if(x==25)  printf("%c\n", 217);
                else if(x%3==1) putchar(193); 
                else            putchar(196);
            else if(y%2==1)
                if(x==0)        putchar(' ');
                else if(x==1)   putchar(195);
                else if(x==25)  printf("%c\n", 180);
                else if(x%3==1) putchar(197); 
                else            putchar(196);
            else  
                if (x==0)       putchar(48+(y/2));
                else if(x==25)  printf("%c\n", 179);
                else if(x%3==1) putchar(179); 
                else if(x%3==2) printf("  ");//contents goes here
}  

int main()
{
    DrawBoard();
    getchar();
}

Its only 8*8 so you would need an extra tile in each dim. Also theres some double border chars to which would look good to divide the 3*3 sections. If you want you could find thier codes on an ascii chart.