invalid use of void expression

Hello everyone,

I am trying to use sprintf, but keep getting error: invalid use of void expression

Code:

---

sprintf(s,"%s",get_l());

---

The function get_l looks like:

Code:

---

void get_l()
{
        FILE *data;
        char buff[1024];
        data = popen("/usr/bin/whoami", "r");
        while(fread(buff, 1, sizeof(buff), data) > 0)
        {
          printf("%s",buff);
        }
        pclose(data);
}

---

If I just call the function in the main it works fine. Thanks in advance.
Brad

Your function isn't returning a value, yet you're trying to use a return value for printing. Try this instead:

Code:

---

char *get_l()
{
        FILE *data;
        static char buff[1024];
        data = popen("/usr/bin/whoami", "r");
        while(fread(buff, 1, sizeof(buff), data) > 0)
        {
          printf("%s",buff);
        }
        pclose(data);

        return buff;
}

---

Of course, that's only going to return the last line that's read. If you want to return all the lines, you'll have to rethink the logic in your function.

What exactly are you expecting from get_l(), which returns NOTHING at the moment.
- the whole file
- some part of the file?

Given your attempted usage, get_l() needs to return some kind of char* result.

that was it, I had it return(buff), but it gave me an error about returning local variable. So I switched it to what I submitted. When I put get_l(); in main it would return current user. I am a little confused.

Did you make buff[] static instead of automatic like I showed you? If so, you shouldn't get a warning about returning a local variable. I highlighted the changes in red, so it's not like they should be hard to find.

no your changes worked perfect. I was just a little confused. If I call get_l(); in main, it does return current user. But when I try to call it from sprintf, I get the error. I just wanted to know why one worked and the other did not.
Thanks again for your help.
Brad

get_l(); alone doesn't try using a return value from the function. You're just calling the function and then moving on. Calling it within an argument to sprintf() uses the return value, so you get the error.

ok that makes sense. Thanks to everyone.
Take Care.