problems on stack.h

i have a code that causes errors in running the program...i use my header file stack.h on my program but it didn't work...what is the problem of that program?

Code:

#define DEFAULT_SIZE 10

class stack//declaration syntax error
{
private:
	int size;
	int top;
	int *values;
public:
	stack(int size=DEFAULT_SIZE);
	/*virtual*/~stack();
	int isFull();
	int isEmpty();
	void push(int);
	int pop(int);
}

stack::stack(int size)
{
this->size=size;
values=new int [size];
top=-1;
}
stack::~stack()
{
delete [] values;
}
int stack::isFull()
{
if(top<size-1)
	{
	return 0;
	}
else
	{
	return 1;
	}
}
int stack:: isEmpty()
{
if(top==-1)
	{
	return 1;
	}
else
	{
	return 0;
	}
}
void stack:: push(int x)
{
if(!isFull())
	{
	top++;
	values[top]=x;
	}
}
int stack::pop(int top)
{
	int retVal=0;
		if(! isEmpty())
		{
		retVal=values[top];
		top--;
		}
return retVal;
}

class as well as new/delete are C++ keywords

So this header cannot be used in the C program

I suppose - even usage of it in the C++ program will cause problems (which are fixable)... But for the C-language this file is totally unusable

Maybe it's the lack of indentation.

Have you tried it with a really simple main(), which say creates a stack, pushes 1 value, pops it off the stack and then crashes?

Posting a small complete example which crashes in a specific way is good.

Posting just a small part of some otherwise massive program with some vague "it doesn't work" is bad.

Code:

class stack//declaration syntax error
{
private:
    int size;
    int top;
    int *values;
public:
    stack(int size=DEFAULT_SIZE);
    /*virtual*/~stack();
    int isFull();
    int isEmpty();
    void push(int);
    int pop(int);
};

Missing semicolon?

But yeah... can a mod move this?

if the stack is not used, i tried to use a stack to read the content of the file and displays the content in reversed

Code:

#include <stdio.h>
#include <conio.h>
#include <string.h>
#include "stack.h"
void main()
{
clrscr();
char str[1500];
char file[10];
char sfile[10];
int x;
FILE *fp1, *fp2;
printf("Enter filename:");
gets(file);
fp1=fopen(file,"r");
printf("Save to:");
gets(sfile);
fp2=fopen(sfile,"w");

if(fgetc(str, sizeof(str), fp1)!=NULL)
           {
                      fputs(str,fp2);
                      printf("Content is:\n &#37;s", str);
           }
else
           {
           printf("cannot open file!!!");
           }

int y=strlen(str);

for(i=0;i<y;i++)
    {
	stach->push(str[i]);
    }
printf("The reversed content is:");
for(int i=0;i<y;i++)
    {
	cout<<stack->pop(i);
    }
fclose(fp1);
fclose(fp2);
getch();
}

by using stack.h in a turbo c library...the improper typedef happens on push and pop stack...what are things do you suggests in this code?

1. int main() faq
2. clrscr is not portable
3. don't use gets. use fgets faq
4. I think you want fgets, not fgetc
5. stach->push(str[i]);
6. what is up with your indenting?
7. did you even try to compile this?

Originally Posted by robwhit

1. int main() faq
2. clrscr is not portable
3. don't use gets. use fgets faq
4. I think you want fgets, not fgetc
5. stach->push(str[i]);
6. what is up with your indenting?
7. did you even try to compile this?

Code:

#include <stdio.h>
#include <conio.h>
#include <string.h>
#include "stack.h"
int main()
{

char str[1500];
char file[10];
char sfile[10];
int x;
FILE *fp1, *fp2;
printf("Enter filename:");
fgets(file);
fp1=fopen(file,"r");
printf("Save to:");
fgets(sfile);
fp2=fopen(sfile,"w");

if(fgetc(str, sizeof(str), fp1)!=NULL)
           {
                      fputs(str,fp2);
                      printf("Content is:\n &#37;s", str);
           }
else
           {
                      printf("cannot open file!!!");
           }

int y=strlen(str);

for(i=0;i<y;i++)
          {
	              stack->push(str[i]);//improper typedef
          }
printf("The reversed content is:");
for(int i=0;i<y;i++)
          {
	              cout<<stack->pop(i);//improper typedef
          }
fclose(fp1);
fclose(fp2);
getch();

return 0;
}

6. there is nothing wrong with the identing
7. i compile this program, but the errors are in the improper typedef

Compiling as C++ I assume, So why'd you post in the C forum?
Pay close attention to point #6...

Code:

#include <stdio.h>
/* #iclude <conio.h> */
#include <string.h>
#include "stack.h"

/* void main()*/ 
int main()
{
     /* clrscr(); */
     
     char str[1500];
     char file[10];
     char sfile[10];
     int x;
     
     FILE *fp1, *fp2;
     printf("Enter filename:");
     /* gets(file); */
     fgets(file, sizeof(file), stdin);
     
     fp1=fopen(file,"r");
     printf("Save to:");
     /* gets(sfile); */
     fgets(file, sizeof(sfile), stdin);
     
     fp2=fopen(sfile,"w");

     if(fgetc(str, sizeof(str), fp1)!=NULL)
     {
          /* You just a single char here, whats up to the rest of them in the file */
          fputs(str,fp2);
          printf("Content is:\n &#37;s", str);
     }
     else
          printf("cannot open file!!!");

     int y=strlen(str);
     
     for(i=0;i<y;i++)
        stach->push(str[i]);

     printf("The reversed content is:");
     
     for(int i=0;i<y;i++)
        /* cout<<stack->pop(i); // This is a C++ standard dont use this in C */
        printf("%c",stack->pop(i));
        
     fclose(fp1);
     fclose(fp2);
     
     /* getch(); */
     getchar();     
     
     return 0;
}

ssharish2005

Originally Posted by blacksnake

Code:

fgets(file); // not how you use fgets. (<--link) also check out the links in my previous post.

fgets(sfile); // ditto
fp2=fopen(sfile,"w");

if(fgetc(str, sizeof(str), fp1)!=NULL) // and still

6. there is nothing wrong with the indenting

not technically, but I still find it it a bit... unusual. Why do you space the braces so far except for the main() function? Why don't you indent code one level in inside the main() function?

7. i compile this program, but the errors are in the improper typedef

that's because of something in your header file. There are no typedef's in the code you just posted.

Originally Posted by ssharish2005

Code:

#include <stdio.h>
/* #iclude <conio.h> */
#include <string.h>
#include "stack.h"

/* void main()*/ 
int main()
{
     /* clrscr(); */
     
     char str[1500];
     char file[10];
     char sfile[10];
     int x;
     
     FILE *fp1, *fp2;
     printf("Enter filename:");
     /* gets(file); */
     fgets(file, sizeof(file), stdin);
     
     fp1=fopen(file,"r");
     printf("Save to:");
     /* gets(sfile); */
     fgets(file, sizeof(sfile), stdin);
     
     fp2=fopen(sfile,"w");

     if(fgetc(str, sizeof(str), fp1)!=NULL)
     {
          /* You just a single char here, whats up to the rest of them in the file */
          fputs(str,fp2);
          printf("Content is:\n %s", str);
     }
     else
          printf("cannot open file!!!");

     int y=strlen(str);
     
     for(i=0;i<y;i++)
        stach->push(str[i]);

     printf("The reversed content is:");
     
     for(int i=0;i<y;i++)
        /* cout<<stack->pop(i); // This is a C++ standard dont use this in C */
        printf("%c",stack->pop(i));
        
     fclose(fp1);
     fclose(fp2);
     
     /* getch(); */
     getchar();     
     
     return 0;
}

ssharish2005

added to stack.h:

Code:

#define dsize 10000

class stack{
public:
	stack(int size=dsize);
	/*virtual*/~stack(void);
	int isFull();
	int isEmpty();
	void push(int);
	int pop(int);
private:
	char size;
	char top;
	char *values;
};

stack::stack(int size)
{
this**size=size;
values=new char [size];
top=-1;
}
stack::~stack()
{
delete [] values;
}
int stack::isFull()
{
if(top<size-1)
	{
	return 0;
	}
else
	{
	return 1;
	}
}
int stack:: isEmpty()
{
if(top==-1)
	{
	return 1;
	}
else
	{
	return 0;
	}
}
void stack:: push(int x)
{
if(!isFull())
	{
	top++;
	values[top]=x;
	}
}
int stack::pop(int top)
{
	int retVal=0;
		if(! isEmpty())
		{
		retVal=values[top];
		top--;
		}
return retVal;
}

too many errors found when i compile it...is there a problem in a program or a .h file? why?