Thread: Trying to make my own reverse string

Code:

int lstrlenQ(const char *s) {
	int i = 0;
	while(*s) {
		s++;
		i++;
	}
	return i;
}

int lReverse(const char *str, char *buffer) {
	int npos = lstrlenQ(str);
	const char *p = str + npos;
	while (npos) {
		*buffer = *p;
		buffer++;
		p--;
		npos--;
	}
	*buffer++ = '\0';
	return 0;
}

But return and empty string...any ideas?

TBH, I have no idea what you're asking at all, but you're assigning the '\0' in the wrong spot I believe. It should be:

Code:

*buffer = '\0'

Originally Posted by drop2kumar

You are reversing the Null character also...so the output string will be Null followed by your string ,so while displaying you are getting empty string which is nothing but Null.In order to solve you can change the line const char *p = str + npos; to const char *p = str + npos-1;

Oh..yeah! I understand

Code:

int lReverse(const char *str, int nSize, char *buffer) {
	const char *p = str + nSize - 1;
	while (nSize) {
		*buffer = *p;
		buffer++;
		p--;
		nSize--;
	}
	*buffer = '\0';
	return 0;
}

Thanks =)